Use returned object in 'function' mode #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include a test + doc updates for this change? |
yocontra
reviewed
Dec 4, 2019
|
I've added another test that I thought would fit, along with some doc changes. Let me know if I've missed anything. Also let me know if the commits need to be re-arranged or squashed. I'm not aware of the policies. |
|
@sam97 Thanks, I'll publish this as a breaking change since some users may have been relying on the function return value being discarded |
|
No problem at all! Thanks for the opportunity. :) Makes sense to play it safe. A suggestion I'd make is that if there are any other breaking changes planned then this could be shelved to ship along with those. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function is provided as parameter, the return value, if it exists, is used as the new
parsedPath. Otherwise, as earlier, the passed parameter is used assuming it has been modified accordingly.Fixes #85