-
Notifications
You must be signed in to change notification settings - Fork 8
Automatically add workshops to website #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good. Detailed tweaks follow.
For the survey form, I think we want to get the coordinator's name and email, and honestly, I don't much care who the instructors and helpers are. Otherwise, event URL, date, time, and venue are good.
I don't think we can collect emails since the Google sheet is public. The best we can do is add an optional contact email and give warning that this information will be public. |
OK -- then let's streamline the form to only collect the workshop URL, date, time, and (optionally) included lessons. |
We'll, instructors and helpers are already optional, I think they are useful information. I also think whether it is in-person or online is also very important to know for someone browsing the info |
Actually, instructors is currently mandatory, I could make it optional |
Ah, yes, cyber- vs meat-space is a useful distinction. |
I could have turned that into a drop down selection, but I wanted it make it easy to indicate a hybrid event. I could make only the online one mandatory and infer the other value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@tkphd A little bit more resilient now to changes in the form data. I've added links to the form on pages that show upcoming workshops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, again!
Looks like commit traffic has trailed off. Is ready to merge, @ocaisa? |
Yes, this is good to go (I think), it will cause a merge conflict in the other PR that I need to fix. |
This pulls the information from the Google Form at https://forms.gle/msY87mszQXUmg4VT9 (well, actually the response spreadsheet). It splits it into past and future workshops and then displays the events on the front page (and some other places too).
Still a little hacky, but it works.