Skip to content

Automatically add workshops to website #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 8, 2021
Merged

Automatically add workshops to website #39

merged 16 commits into from
Jul 8, 2021

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Jul 5, 2021

This pulls the information from the Google Form at https://forms.gle/msY87mszQXUmg4VT9 (well, actually the response spreadsheet). It splits it into past and future workshops and then displays the events on the front page (and some other places too).

Still a little hacky, but it works.

@ocaisa ocaisa requested review from reid-a and tkphd as code owners July 5, 2021 15:44
Copy link
Member

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good. Detailed tweaks follow.

For the survey form, I think we want to get the coordinator's name and email, and honestly, I don't much care who the instructors and helpers are. Otherwise, event URL, date, time, and venue are good.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 7, 2021

I don't think we can collect emails since the Google sheet is public. The best we can do is add an optional contact email and give warning that this information will be public.

@tkphd
Copy link
Member

tkphd commented Jul 7, 2021

OK -- then let's streamline the form to only collect the workshop URL, date, time, and (optionally) included lessons.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 7, 2021

We'll, instructors and helpers are already optional, I think they are useful information. I also think whether it is in-person or online is also very important to know for someone browsing the info

@ocaisa
Copy link
Member Author

ocaisa commented Jul 7, 2021

Actually, instructors is currently mandatory, I could make it optional

@tkphd
Copy link
Member

tkphd commented Jul 7, 2021

Ah, yes, cyber- vs meat-space is a useful distinction.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 7, 2021

I could have turned that into a drop down selection, but I wanted it make it easy to indicate a hybrid event. I could make only the online one mandatory and infer the other value

Copy link
Member

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkphd
Copy link
Member

tkphd commented Jul 7, 2021

  • Allowing for hybrid events is good, please keep it that way.
  • Having the Instructors' names optional would be preferable.

@ocaisa
Copy link
Member Author

ocaisa commented Jul 8, 2021

@tkphd A little bit more resilient now to changes in the form data. I've added links to the form on pages that show upcoming workshops

@ocaisa ocaisa mentioned this pull request Jul 8, 2021
Copy link
Member

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again!

@tkphd
Copy link
Member

tkphd commented Jul 8, 2021

Looks like commit traffic has trailed off. Is ready to merge, @ocaisa?

@ocaisa
Copy link
Member Author

ocaisa commented Jul 8, 2021

Yes, this is good to go (I think), it will cause a merge conflict in the other PR that I need to fix.

@tkphd tkphd merged commit d5ddbee into main Jul 8, 2021
@tkphd tkphd deleted the workshop_list branch July 8, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants