Skip to content

Use standard Gemfile from carpentries/lesson-example. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2021
Merged

Use standard Gemfile from carpentries/lesson-example. #40

merged 2 commits into from
Mar 25, 2021

Conversation

vinisalazar
Copy link
Contributor

Addressing #39.

@vinisalazar vinisalazar requested a review from a team March 25, 2021 19:33
@tkphd
Copy link
Member

tkphd commented Mar 25, 2021

This represents a breaking change, and reveals a silent error in our integration tests.

From check_lesson_and_build_default:

bundler: command not found: mdl

We put mdl and kramdown-parser-gfm in our Gemfile for good reasons.

@tkphd tkphd mentioned this pull request Mar 25, 2021
Open
@tkphd tkphd closed this Mar 25, 2021
@vinisalazar vinisalazar mentioned this pull request Mar 25, 2021
Closed
@tkphd tkphd reopened this Mar 25, 2021
tkphd
tkphd approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the contribution 🎉

@tkphd tkphd merged commit 601cb0c into hpc-carpentry:gh-pages Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkphd tkphd tkphd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinisalazar @tkphd