Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying the use of MACROs and APIs in pdc_malloc.h all over the project #155

Closed
zhangwei217245 opened this issue Oct 13, 2023 · 4 comments
Assignees
Labels
decision: help wanted Extra attention is needed priority: low Low priority type: enhancement New feature or request
Milestone

Comments

@zhangwei217245
Copy link
Collaborator

In pdc_malloc.h, we provided both APIs and MACROs for memory allocation, but it seems that MACROs are not necessary.

We need to take some time to evaluate whether we should take only APIs or only MACROs when it is in use. Once decided, we need to unify the use of them either in APIs or MACROs, throughout the project.

@zhangwei217245 zhangwei217245 self-assigned this Oct 13, 2023
@zhangwei217245 zhangwei217245 added priority: low Low priority type: enhancement New feature or request labels Oct 13, 2023
@zhangwei217245 zhangwei217245 removed their assignment Oct 13, 2023
@zhangwei217245 zhangwei217245 self-assigned this Oct 26, 2023
@jeanbez
Copy link
Member

jeanbez commented Dec 5, 2023

Let's switch to using the PDC malloc ones instead of the macros and directly calling malloc.

@jeanbez jeanbez added the decision: help wanted Extra attention is needed label Dec 5, 2023
@jeanbez
Copy link
Member

jeanbez commented Dec 5, 2023

@jeanbez
Copy link
Member

jeanbez commented Mar 5, 2024

@hyunjuooh have you opened the new PR with this fix?

@hyunjuooh
Copy link
Contributor

I have opened the new PR today. Thank you for the notification.

@jeanbez jeanbez added this to the v.0.5 milestone Jun 4, 2024
@jeanbez jeanbez closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision: help wanted Extra attention is needed priority: low Low priority type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants