Switching PDC_MALLOC macro to PDC_malloc #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyunjuooh could you help fix the formatting issues in the PR? If you click on 'Details' in the failed check you will see what needs to be changed. Thanks! |
|
Thank you for the instructions. Also, I commented out the PDC_MALLOC macro in ./src/commons/utils/include/pdc_malloc.h to check if the changed code didn't cause any compile issues. Would it be okay to leave it that way, or would it be preferable to change it back? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues / Pull Requests
Related Issue: Unifying the use of MACROs and APIs in pdc_malloc.h all over the project #155
Description
Removed PDC_MALLOC, PDC_CALLOC, PDC_FREE macro.