Add rocksdb support #146
Closed
Add rocksdb support #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbez
reviewed
Oct 10, 2023
|
Can you also please add/update the documentation accordingly? |
zhangwei217245
requested changes
Oct 10, 2023
There was a problem hiding this comment.
I have created a ticket for this PR: #148
Please take the following changes:
- RocksDB implementation of metadata and relative metadata search functionality
- Runtime option for metadata & metadata search functions to call different implementations (passed by RPC parameters)
- CMake support for enabling/disabling RocksDB . If runtime flag is calling a disabled support, just print do not support and return empty result.
- Documentation on How metadata is stored in RocksDB and how metadata search is performed, including: where the db file is stored: tmpfs, how metadata tag is stored: rock_key = ObjID_attrKey rock_value=attrVal. How metadata search is done: a full scan across all key-value records in RocksDB.
|
Added documentation. |
zhangwei217245
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Going to create a new pull request with both RocksDB and SQLite support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with rocksdb 8.1.1
Also added a serial kvtag test