fixes for MacOS and new CI to prevent future breaks #164
Conversation
jeanbez
added
type: bug
|
Tested on my Mac with the guide provided by Jean Luca, no issue with compilation. the first 66 ctest ran smoothly, and like the situation in a linux PC, the 67th test takes a long time. some flags used for installing libfabric and mercury on MacOS are different, I suggest we should open a dedicated subsection in the installation guide document to provide clear commands for Mac users. Below are the flags provided by Jean Luca and they are working on my Mac: libfabric: ./configure --prefix=<install_path> CFLAG=-O2 --enable-sockets=yes --enable-tcp=yes --enable-udp=yes --enable-rxm=yes Also, documentation should be added about authorizing all mercury and PDC ctests in MacOS to avoid dialog box being popped continuously. |
|
Test #67 and later just timed out.
Would it be possible if we can setup a shorter timeout limit for these ctests? |
There is a global way to set the timeout directly in CMake, we can either set the timeout for each test or you can change the way you call |
|
Updated documentation and the CI can now run in macOS runners after GitHub's latest updates on their support. |
* include MacOS in CI * include dependencies * replace TCP with sockets * add libuuid * fix find UUID to correctly locate files in Ubuntu and MacOS * fix random segfault in strdup + malloc due to wrong allocation * ensure consistent use of defined variables * change transport for MacOS tests * update env * update dependencies-macos.sh * replace found to TRUE/FALSE * update documentation with timeout and MacOS specifics * fix git link to avoid authentication * change transport for tests * configure network for MacOS tests --------- Co-authored-by: github-actions <github-actions[bot]@users.noreply.github.com>
Fixes for MacOS by correctly handle finding
UUID_LIBRARY(the current code was mixing the library provided by the system, but no the headers, and getting partially overwritten by a local user installation). Some tests were also breaking due to wrong memory allocation. For MacOS we also need to run mercury withsocketsinstead oftcp.We also include a new CI check where we compile PDC with MacOS, but we do not run tests due to some issues in Github provided runners (actions/runner-images#3885)