Grouped commons tests into folders #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also changes the src/tests/CmakeLists.txt to build tests within their new folders
houjun
requested changes
Mar 3, 2025
src/tests/CMakeLists.txt
Outdated
| tags/kvtag_affix_query_scale | ||
| tags/kvtag_add_get_benchmark | ||
| tags/kvtag_add_get_scale | ||
| misc/llsm_idioms_bench |
There was a problem hiding this comment.
llsm_idioms_bench and idioms_ci_test can also go to tags/
src/tests/CMakeLists.txt
Outdated
| cont/cont_del | ||
| cont/cont_getid | ||
| cont/cont_tags | ||
| locks/consistency_semantics |
There was a problem hiding this comment.
we probably don't need a lock/ sub-dir, consistency_semantics can go to misc/
for blocked_lock.c, as well as other tests that include "PDCreg_obtain_lock / PDCreg_release_lock" you can create a new deprecated sub-dir and put them there, they are using the old deprecated APIs, which have been replaced with the region transfer APIs.
|
@jeanbez mentioned we also need to make sure the spack package still works with these new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also changes the
src/tests/CmakeLists.txtto build tests within their new foldersTests are categorized into the following directories:
analysis/cont/dart/data_server/deprecated/misc/obj/prop/query/region/tags/transform/