Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the return value of PDC_Client_init in PDC_init #230

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Check the return value of PDC_Client_init in PDC_init #230

wants to merge 2 commits into from

Conversation

TheAssembler1
Copy link
Collaborator

@TheAssembler1 TheAssembler1 commented Mar 15, 2025 •
edited
Loading

What changes are proposed in this pull request?

PDC_init was not checking the return value of PDC_Client_init.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@TheAssembler1 TheAssembler1 requested a review from a team as a code owner March 15, 2025 13:35
@TheAssembler1 TheAssembler1 force-pushed the pdc_init_check_client_error branch from 919d8a7 to 663f3bb Compare March 15, 2025 13:42
@TheAssembler1 TheAssembler1 changed the title Check that the return value of PDC_Client_init in PDC_init Check the return value of PDC_Client_init in PDC_init Mar 15, 2025
@sbyna sbyna requested a review from jeanbez March 18, 2025 10:42
@jeanbez jeanbez added the type: enhancement New feature or request label Mar 19, 2025
@TheAssembler1 TheAssembler1 mentioned this pull request Mar 20, 2025
Open
2 tasks
@TheAssembler1
Change return to 0
b5b54ae 
This will make is simpler when merging hpc-io#233 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houjun houjun houjun approved these changes

@sbyna sbyna sbyna approved these changes

@jeanbez jeanbez Awaiting requested review from jeanbez

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheAssembler1 @houjun @sbyna @jeanbez