Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #91

Merged
merged 19 commits into from
Jul 19, 2023
Merged

Update documentation #91

merged 19 commits into from
Jul 19, 2023

Conversation

jeanbez
Copy link
Member

@jeanbez jeanbez commented Jun 21, 2023

Update documentation with both code and design.

Preview available at https://pdc.readthedocs.io/en/code-docs

@jeanbez jeanbez requested review from houjun and sbyna June 21, 2023 18:49
@jeanbez jeanbez added the type: documentation Improvements or additions to documentation label Jun 21, 2023
Copy link
Member

@houjun houjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houjun
Copy link
Member

houjun commented Jun 27, 2023

@jeanbez, the width of the content on the pages seems to be fixed, and looks a bit narrow to me as it only covers the left half of the window if I view it full screen. Is this intended?

@jeanbez
Copy link
Member Author

jeanbez commented Jun 27, 2023

@houjun, that is the default width for most readthedocs templates, but I believe we could increase it as needed. I would not recommend making it fully wide as it might look strange. Maybe we can double the current width?

@houjun
Copy link
Member

houjun commented Jun 27, 2023

There are some code blocks that are just a bit too long for the current width, I'm debating whether to do more line breaks or increase the content width by something like 20%. What do you think?

@jeanbez
Copy link
Member Author

jeanbez commented Jun 27, 2023

Hmm, got it. I personally prefer to have commands broken into multiple lines; it improves readability. But I can give it a try by increasing it by 20% to see if that improves.

@jeanbez
Copy link
Member Author

jeanbez commented Jun 27, 2023

@houjun, can you give it another try now? If you do not see any changes, please force refresh the page to refresh the CSS.

I believe it looks better now, but there are still some commands that would benefit from being split into multiple lines.

@houjun
Copy link
Member

houjun commented Jun 27, 2023

Yes, once we merge the other pull request (which I added line breaks) to this branch then everything should fit within the page width.

* Update README.md

* Update getting_started.rst

* Update getting_started.rst
README.md Outdated Show resolved Hide resolved
Copy link
Member

@sbyna sbyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of blocks of text that needs to be changed.

README.md Outdated Show resolved Hide resolved
@jeanbez jeanbez requested a review from sbyna July 19, 2023 16:56
README.md Outdated Show resolved Hide resolved
@jeanbez jeanbez merged commit 452a4af into stable Jul 19, 2023
3 checks passed
@jeanbez jeanbez self-assigned this Jul 19, 2023
@jeanbez jeanbez deleted the code-docs branch October 10, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants