Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

remove embedded Bats #553

Closed
reidpr opened this issue Sep 24, 2019 · 0 comments
Closed

remove embedded Bats #553

reidpr opened this issue Sep 24, 2019 · 0 comments
Assignees
@reidpr
Labels
enhancement
Milestone
0.12

Comments

@reidpr
Copy link
Collaborator

reidpr commented Sep 24, 2019

We've been discussing simplifying the test suite by removing the embedded Bats.

Currently, make install does not install the embedded Bats (test/Makefile:134 has an extra test/). Thus, the Vagrantfile cannot pass tests, because the system Bats doesn't work (#552) and the embedded Bats isn't installed.

Rather than fix the install, why don't we go ahead and just remove the embedded Bats.

@j-ogas, opinions?
@reidpr reidpr added this to the next milestone Sep 24, 2019
@reidpr reidpr self-assigned this Sep 24, 2019
@reidpr reidpr mentioned this issue Sep 25, 2019
Merged
@reidpr reidpr modified the milestones: next, 0.12 Sep 30, 2019
@reidpr reidpr closed this as completed in 0a2c810 Sep 30, 2019
@reidpr reidpr mentioned this issue Oct 24, 2019
Merged
j-ogas pushed a commit that referenced this issue Nov 1, 2019
@reidpr @j-ogas
PR #556 from me: remove Bats submodule and work around Bats bug (closes
6528432 
#552, closes #553)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reidpr reidpr

Labels
enhancement
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
1 participant
@reidpr