daos: copy user attrs and cont props on create #478
Conversation
daltonbohning
force-pushed
the
dbohninx-cont-meta
branch
from
7c45af2 to
c2b619c
Compare
src/common/mfu_daos.c
Outdated
| props->dpp_entries[12].dpe_type = DAOS_PROP_CO_OWNER_GROUP; | ||
| props->dpp_entries[13].dpe_type = DAOS_PROP_CO_DEDUP; | ||
| props->dpp_entries[14].dpe_type = DAOS_PROP_CO_DEDUP_THRESHOLD; | ||
| props->dpp_entries[15].dpe_type = DAOS_PROP_CO_ALLOCED_OID; |
There was a problem hiding this comment.
@daltonbohning this property should not be set for POSIX containers.
There was a problem hiding this comment.
@dsikich Thanks! Specifically, it should not be set when we use DFS. I think we should still set it for POSIX -> POSIX with the Object API, just not DFS. It seemed the simplest way was to just pass a get_oid flag
There was a problem hiding this comment.
@dsikich Thanks! Specifically, it should not be set when we use DFS. I think we should still set it for POSIX -> POSIX with the Object API, just not DFS. It seemed the simplest way was to just pass a
get_oidflag
@daltonbohning yeah, I agree 👍
When creating a new DAOS container, copy the user attributes and container properties from the src container. Signed-off-by: Dalton Bohning <daltonx.bohning@intel.com>
daltonbohning
force-pushed
the
dbohninx-cont-meta
branch
from
c2b619c to
ca8992a
Compare
There was a problem hiding this comment.
@daltonbohning looks good. There will eventually be a DFS version of serialization/deserialization, so I can just update the flag when the container is serialized for that case whenever it gets added.
|
@adammoody can you take a look at this one? I am working on an option/feature that builds on this PR. |
| rc = daos_cont_list_attr(coh, name_buf, &total_size, NULL); | ||
| if (rc != 0) { | ||
| MFU_LOG(MFU_LOG_ERR, "failed to list user attributes "DF_RC, DP_RC(rc)); | ||
| rc = 1; | ||
| goto out; | ||
| } |
There was a problem hiding this comment.
Just curious about the daos_cost_list_attr interface. Is total_size used as an input parameter here to specify the buffer size?
If so, I'm guessing this function might return an error if the attribute list size has increased, since the first time this was called.
And I suspect it's valid for the attribute list size to be less than what it was?
There was a problem hiding this comment.
@adammoody I believe it is valid for it to be less than it was, but I will note that we should return an error if the attribute size has increased since the first time it was called.
There was a problem hiding this comment.
@adammoody @dsikich Yes, it is possible for the actual size to change between the first call to daos_cont_list_attr (which just gets the size) and the second call (which gets the names).
https://github.com/daos-stack/daos/blob/011b78cb28aaf162af635f37d1fcabc62076ef0b/src/include/daos_cont.h#L382-L399
I think this is how it works, based on other DAOS paradigms:
- If size is less than the size passed in
- The output size set accordingly, since it's passed by reference, and the buffer contains all the data
- If size is more than the size passed in
- The output size is set accordingly, and the buffer is truncated
The "foolproof" way to handle this would be to have a retry loop, and realloc and fetch every time the size is more than the size of the buffer.
|
Thanks @daltonbohning and @dsikich . This looks good to me. |
Thanks @adammoody ! |
When creating a new DAOS container, copy the user attributes
and container properties from the src container.
Signed-off-by: Dalton Bohning daltonx.bohning@intel.com