Skip to content

Commit

Permalink
sessions: remove mpi_win_create_from_group
Browse files Browse the repository at this point in the history
this was not part of the MPI 4.0 standard

related to #54

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
  • Loading branch information
hppritcha committed Jun 14, 2021
1 parent dec89cd commit f3cbf36
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 112 deletions.
6 changes: 0 additions & 6 deletions ompi/include/mpi.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -1985,9 +1985,6 @@ OMPI_DECLSPEC int MPI_Waitsome(int incount, MPI_Request array_of_requests[],
MPI_Status array_of_statuses[]);
OMPI_DECLSPEC int MPI_Win_allocate(MPI_Aint size, int disp_unit, MPI_Info info,
MPI_Comm comm, void *baseptr, MPI_Win *win);
OMPI_DECLSPEC int MPI_Win_allocate_from_group (MPI_Aint size, int disp_unit, MPI_Info info,
MPI_Group group, const char *tag, void *baseptr,
MPI_Win *win);
OMPI_DECLSPEC int MPI_Win_allocate_shared(MPI_Aint size, int disp_unit, MPI_Info info,
MPI_Comm comm, void *baseptr, MPI_Win *win);
OMPI_DECLSPEC int MPI_Win_allocate_shared_from_group (MPI_Aint size, int disp_unit, MPI_Info info,
Expand Down Expand Up @@ -2710,9 +2707,6 @@ OMPI_DECLSPEC int PMPI_Waitsome(int incount, MPI_Request array_of_requests[],
MPI_Status array_of_statuses[]);
OMPI_DECLSPEC int PMPI_Win_allocate(MPI_Aint size, int disp_unit, MPI_Info info,
MPI_Comm comm, void *baseptr, MPI_Win *win);
OMPI_DECLSPEC int PMPI_Win_allocate_from_group (MPI_Aint size, int disp_unit, MPI_Info info,
MPI_Group group, const char *tag, void *baseptr,
MPI_Win *win);
OMPI_DECLSPEC int PMPI_Win_allocate_shared(MPI_Aint size, int disp_unit, MPI_Info info,
MPI_Comm comm, void *baseptr, MPI_Win *win);
OMPI_DECLSPEC int PMPI_Win_allocate_shared_from_group (MPI_Aint size, int disp_unit, MPI_Info info,
Expand Down
1 change: 0 additions & 1 deletion ompi/mpi/c/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ libmpi_c_mpi_la_SOURCES = \
get.c \
put.c \
win_allocate.c \
win_allocate_from_group.c \
win_allocate_shared.c \
win_allocate_shared_from_group.c \
win_attach.c \
Expand Down
82 changes: 0 additions & 82 deletions ompi/mpi/c/win_allocate_from_group.c

This file was deleted.

20 changes: 0 additions & 20 deletions ompi/win/win.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,26 +326,6 @@ ompi_win_allocate(size_t size, int disp_unit, opal_info_t *info,
return OMPI_SUCCESS;
}

int ompi_win_allocate_from_group (size_t size, int disp_unit, opal_info_t *info, ompi_group_t *group,
const char *tag, void *baseptr, ompi_win_t** newwin)
{
/* NTH: dummy implementation until the osc modules are updated for group communicator
* creation. This implemention will probably continue to exist for modules that do
* not provide group-based window creation. */
ompi_communicator_t *comm;
int rc;

rc = ompi_comm_create_from_group (group, tag, info, MPI_ERRHANDLER_NULL, &comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS == rc)) {
return rc;
}

rc = ompi_win_allocate (size, disp_unit, info, comm, baseptr, newwin);
ompi_comm_free (&comm);
return rc;
}


int
ompi_win_allocate_shared(size_t size, int disp_unit, opal_info_t *info,
ompi_communicator_t *comm, void *baseptr, ompi_win_t **newwin)
Expand Down
3 changes: 0 additions & 3 deletions ompi/win/win.h
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ int ompi_win_create_from_group (void *base, size_t size, int disp_unit,
ompi_win_t **newwin);
int ompi_win_allocate(size_t size, int disp_unit, opal_info_t *info,
ompi_communicator_t *comm, void *baseptr, ompi_win_t **newwin);
int ompi_win_allocate_from_group (size_t size, int disp_unit, opal_info_t *info,
ompi_group_t *group, const char *tag, void *baseptr,
ompi_win_t **newwin);
int ompi_win_allocate_shared(size_t size, int disp_unit, opal_info_t *info,
ompi_communicator_t *comm, void *baseptr, ompi_win_t **newwin);
int ompi_win_allocate_shared_from_group (size_t size, int disp_unit, opal_info_t *info,
Expand Down

0 comments on commit f3cbf36

Please sign in to comment.