Skip to content

817 automatically perform module purge before building tests #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Paul-Ferrell merged 18 commits into from
May 20, 2025
Merged

817 automatically perform module purge before building tests #834

Paul-Ferrell merged 18 commits into from
May 20, 2025

Conversation

@hwikle-lanl
Copy link
Collaborator

@hwikle-lanl hwikle-lanl commented Apr 2, 2025

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl added this to the 2.5 milestone Apr 2, 2025
@hwikle-lanl hwikle-lanl self-assigned this Apr 2, 2025
@hwikle-lanl hwikle-lanl linked an issue Apr 2, 2025 that may be closed by this pull request
Automatically perform module purge before building tests #817
Closed
@Paul-Ferrell
Copy link
Collaborator

Paul-Ferrell commented Apr 2, 2025

This should be an option to build/run, but the default should be 'true'.

@hwikle-lanl hwikle-lanl force-pushed the 817-automatically-perform-module-purge-before-building-tests branch from 1548921 to 227fc75 Compare April 2, 2025 20:38
@hwikle-lanl hwikle-lanl force-pushed the 817-automatically-perform-module-purge-before-building-tests branch from 078143f to 0e5e4cb Compare April 28, 2025 17:39
@Paul-Ferrell
Copy link
Collaborator

Paul-Ferrell commented Apr 28, 2025

I saw that you added a commit that module purges only when modules are specified. It should be always (if enabled), with checks for whether a module system is present (IE - does the module alias exist?

Paul-Ferrell
Paul-Ferrell requested changes Apr 28, 2025
View reviewed changes
@hwikle-lanl hwikle-lanl force-pushed the 817-automatically-perform-module-purge-before-building-tests branch from ab1517f to 44ed410 Compare April 30, 2025 19:16
@hwikle-lanl hwikle-lanl force-pushed the 817-automatically-perform-module-purge-before-building-tests branch from 16b74fd to 4809ee5 Compare May 20, 2025 15:10
@Paul-Ferrell Paul-Ferrell merged commit 2e612d8 into develop May 20, 2025
7 checks passed
hwikle-lanl added a commit that referenced this pull request Jul 15, 2025
@hwikle-lanl
817 automatically perform module purge before building tests (#834)
7e7c846 
* Perform module purge before building

* Various changes

* Purge modules before building and running

* Only perform module purge when modules are specified

* Add argument to disable module purging

* Add purge_modules option to build and run

* Revert commits on wrong branch

* Remove module purge cmd line arg

* Make module purge unit test more robust

* Made some progress

* Fix module purge in build/run script

* Fix module purge run test

* Fix module purge build unit test

* Fix log test

* Skip module purge tests when no module syste

* Attempt to fix module purge

* Fix log command test

* Fix purging behavior in unit tests (maybe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Paul-Ferrell Paul-Ferrell Paul-Ferrell approved these changes

@francinelapid francinelapid Awaiting requested review from francinelapid

Assignees

@hwikle-lanl hwikle-lanl

Labels

feature request

Projects

None yet

Milestone

2.5

Development

Successfully merging this pull request may close these issues.

Automatically perform module purge before building tests

3 participants

@hwikle-lanl @Paul-Ferrell