Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] fix bug caused by perf version #6156

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

duanjunwen
Copy link
Member

@duanjunwen duanjunwen commented Dec 10, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Solve: ImportError: cannot import name 'EncoderDecoderCache' from 'transformers'
In test machine, peft==0.14 and transformers==4.39 is conflict in import EncoderDecoderCache (which is a new feature in transformers==4.44). So we modify this issue.
Error detail see: https://github.com/hpcaitech/ColossalAI/actions/runs/12233883342/job/34167440756?pr=6150

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@duanjunwen duanjunwen requested a review from a team as a code owner December 10, 2024 03:32
@duanjunwen duanjunwen requested a review from ver217 December 10, 2024 05:41
@flybird11111 flybird11111 merged commit 8d826a3 into hpcaitech:main Dec 10, 2024
4 checks passed
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Dec 12, 2024
@duanjunwen duanjunwen deleted the hotfix/fix_perf_version branch December 13, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants