Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Observable JS as dependency #314

Closed
JamesDeFabia opened this issue Aug 16, 2022 · 0 comments · Fixed by #320
Closed

Add Observable JS as dependency #314

JamesDeFabia opened this issue Aug 16, 2022 · 0 comments · Fixed by #320
Assignees
@GordonSmith
Labels
notebook
Milestone
ECL Notebook V0.0

Comments

@JamesDeFabia
Copy link
Contributor

OJS is needed for notebooks, so please add it as a dependency so it installs the extension automatically
@GordonSmith GordonSmith self-assigned this Aug 17, 2022
@GordonSmith GordonSmith added this to the ECL Notebook V0.0 milestone Aug 17, 2022
GordonSmith added a commit to GordonSmith/vscode-ecl that referenced this issue Aug 18, 2022
@GordonSmith
fix(notebook): Add ObservableJS dependency
5f84ed0 
Fixes hpcc-systems#314

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith mentioned this issue Aug 18, 2022
Merged
GordonSmith added a commit that referenced this issue Aug 18, 2022
@GordonSmith
Merge pull request #320 from GordonSmith/GH-314-OJS_DEP
e9d7106 
fix(notebook):  Add ObservableJS dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GordonSmith GordonSmith

Labels
notebook
Projects
None yet
Milestone
ECL Notebook V0.0
Development

Successfully merging a pull request may close this issue.

fix(notebook): Add ObservableJS dependency GordonSmith/vscode-ecl
2 participants
@JamesDeFabia @GordonSmith