feat: Add improved platform support #196

GordonSmith · 2020-09-17T14:29:56Z

Added Workunit Tree
Added Submit / Compile buttons
Added pinned launch configuration
Added eclcc log file override

Fixes #191
Fixes #188
Fixes #187
Fixes #190
Fixes #143
Fixes #184

Signed-off-by: Gordon Smith GordonJSmith@gmail.com

GordonSmith · 2020-09-17T14:31:12Z

@jbrundage please review

GordonSmith · 2020-09-17T14:33:49Z

@jbrundage please review

GordonSmith · 2020-09-17T15:43:19Z

README.md

-  // Open Workunits in external browser.
-  "ecl.WUOpenExternal": true
+  // Write eclcc logfile to specified file.
+  "ecl.eclccLogfile": ""


GordonSmith · 2020-09-17T15:43:39Z

README.md

+|![Submit](resources/light-png/play.png) Submit | F5 | Submit ECL |
+|![Compile](resources/light-png/file-binary.png) Compile | | Compile ECL |
+| Syntax Check | F7 | Save and check syntax of current file |
+| Language Reference Lookup | shift + F1 | Toggle between "My" and "All" Workunits |


Wrong description

GordonSmith · 2020-09-17T15:43:55Z

README.md

+|---------------------------|:--------:|------------------------------------------------------------------|
+|![My Workunits](resources/light-png/person.png) My workunits | | Toggle between "My" and "All" Workunits |
+|![All Workunits](resources/light-png/organization.png) All workunits | | Toggle between "My" and "All" Workunits |
+|![Refresh](resources/light-png/refresh.png) ECL Watch | | Refresh Tree |


Wrong command string

GordonSmith · 2020-09-17T15:49:42Z

src/ecl/check.ts

@@ -74,7 +74,7 @@ function checkUri(uri: vscode.Uri, eclConfig: vscode.WorkspaceConfiguration): Pr
    if (uri) {
        const wsf = vscode.workspace.getWorkspaceFolder(uri);
        if (wsf) {
-            vscode.window.setStatusBarMessage(`Syntax Check:  ${path.relative(wsf.uri.fsPath, uri.fsPath)}`);
+            //             vscode.window.setStatusBarMessage(`Syntax Check:  ${path.relative(wsf.uri.fsPath, uri.fsPath)}`);


Commented code.

GordonSmith · 2020-09-17T15:51:33Z

src/ecl/eclWatchDocument.ts

+
+    public static register(context: vscode.ExtensionContext): vscode.Disposable {
+
+        // vscode.workspace.registerTextDocumentContentProvider("cowsay", new MyProvider());


GordonSmith · 2020-09-17T15:52:14Z

src/ecl/eclWatchDocument.ts

+    resolveCustomEditor(document: vscode.CustomDocument, webviewPanel: vscode.WebviewPanel, token: vscode.CancellationToken): void | Thenable<void> {
+        throw new Error("YYYMethod not implemented.");
+    }
+}


Remove entire file

GordonSmith · 2020-09-17T15:55:26Z

src/eclwatch.tsx

+const bodyStyles = window.getComputedStyle(document.body);
+
+const backColor = bodyStyles.getPropertyValue("--vscode-editor-background");
+const foreColour = bodyStyles.getPropertyValue("--vscode-input-foreground");//Palette.textColor(backColor);


commented code

GordonSmith · 2020-09-17T15:56:15Z

src/eclwatch.tsx

+
+// const oldState = vscode.getState() || { url: "" };
+// const iframe: HTMLIFrameElement = document.getElementById("myFrame") as any;
+// iframe.src = oldState.url;


Commented code

GordonSmith · 2020-09-17T15:56:41Z

src/eclwatch.tsx

+
+//  Local debugging without VS Code
+if (document.location.protocol === "file:") {
+    //render("http", "10.173.14.207", "8010", "gosmith", "28Ee1$BHoJvNOTk$KL6F", "W20200910-090123");


Commented code

GordonSmith · 2020-09-17T15:59:09Z

src/eclwatch/WUResultFluent.tsx

+    const startIndex = loremIndex + wordCount > LOREM_IPSUM.length ? 0 : loremIndex;
+    loremIndex = startIndex + wordCount;
+    return LOREM_IPSUM.slice(startIndex, loremIndex).join(" ");
+}


Remove file

GordonSmith · 2020-09-17T16:00:07Z

src/eclwatch/WUResultStore.ts

+            totalLength: retVal.then(response => response.totalLength)
+        });
+    }
+}


Check if this custom version is needed.

GordonSmith · 2020-09-17T16:02:17Z

test.html

+    <iframe id="myFrame" src="http://10.173.14.207:8010/esp/files/stub.htm"
+        style="position:fixed; top:0; left:0; bottom:0; right:0; width:100%; height:100%; border:none; margin:0; padding:0; overflow:hidden; z-index:999999;">
+        Your browser doesn't support iframes
+    </iframe>
 </body>

 </html>


GordonSmith · 2020-09-17T16:05:50Z

webview-test.html

+
+</body>
+
+</html>


GordonSmith · 2020-09-17T16:06:16Z

webview-styles.txt

+--vscode-gitDecoration-untrackedResourceForeground:#73c991;
+--vscode-gitDecoration-ignoredResourceForeground:#8c8c8c;
+--vscode-gitDecoration-conflictingResourceForeground:#6c6cc4;
+--vscode-gitDecoration-submoduleResourceForeground:#8db9e2;


Added Workunit Tree Added Submit / Compile buttons Added pinned launch configuration Added eclcc log file override Fixes hpcc-systems#191 Fixes hpcc-systems#188 Fixes hpcc-systems#187 Fixes hpcc-systems#190 Fixes hpcc-systems#143 Fixes hpcc-systems#184 Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>

GordonSmith force-pushed the WU_TREE branch from e51586b to f2ed30c Compare September 17, 2020 14:33

GordonSmith force-pushed the WU_TREE branch 2 times, most recently from 0bd3921 to bd39d9f Compare September 17, 2020 15:01

GordonSmith commented Sep 17, 2020

View reviewed changes

GordonSmith force-pushed the WU_TREE branch from bd39d9f to 1a3f243 Compare September 17, 2020 15:57

GordonSmith commented Sep 17, 2020

View reviewed changes

webview-test.html Outdated

</body>

</html>

Copy link

Member Author

GordonSmith Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

GordonSmith commented Sep 17, 2020

View reviewed changes

GordonSmith force-pushed the WU_TREE branch from 1a3f243 to 22e3cd8 Compare September 17, 2020 16:19

jbrundage approved these changes Sep 17, 2020

View reviewed changes

GordonSmith merged commit 2e299d9 into hpcc-systems:master Sep 18, 2020

GordonSmith deleted the WU_TREE branch September 18, 2020 06:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add improved platform support #196

feat: Add improved platform support #196

GordonSmith commented Sep 17, 2020

GordonSmith commented Sep 17, 2020

GordonSmith commented Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020

GordonSmith Sep 17, 2020


		public static register(context: vscode.ExtensionContext): vscode.Disposable {

		// vscode.workspace.registerTextDocumentContentProvider("cowsay", new MyProvider());

feat: Add improved platform support #196

feat: Add improved platform support #196

Conversation

GordonSmith commented Sep 17, 2020

GordonSmith commented Sep 17, 2020

GordonSmith commented Sep 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment