Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add WUShowResults setting #358

Merged
merged 1 commit into from
Oct 26, 2023
Merged

feat: Add WUShowResults setting #358

merged 1 commit into from
Oct 26, 2023

Conversation

GordonSmith
Copy link
Member

Available options:

  • internal
  • external
  • disabled

dehilsterlexis
dehilsterlexis suggested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@dehilsterlexis dehilsterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the missing string(s) for translations.

package.json Show resolved Hide resolved
@GordonSmith
feat: Add WUShowResults setting
75613c0 
Available options:
* internal
* external
* disabled

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
dehilsterlexis
dehilsterlexis approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dehilsterlexis dehilsterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GordonSmith GordonSmith merged commit 1d206ad into hpcc-systems:trunk Oct 26, 2023
1 check passed
@GordonSmith GordonSmith deleted the GH-357 branch October 26, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehilsterlexis dehilsterlexis dehilsterlexis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @dehilsterlexis