fix: add ask to delete to delete workunits #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonSmith
requested changes
Feb 6, 2024
src/ecl/eclWatchTree.ts
Outdated
| if (!selection || selection.label == localize("No")) | ||
| return; | ||
| this._wu.delete().then(() => this._tree.refresh()); | ||
| }); |
|
@dehilsterlexis Looks like you merged trunk into this branch, instead of rebasing this branch onto upstream/trunk? |
|
@GordonSmith I tried using the conflict resolution in github and it added a second commit. |
Signed-off-by: David de Hilster <david.dehilster@lexisnexisrisk.com>
GordonSmith
force-pushed
the
ADD_ASK_DELETE_WU
branch
from
7aa0a02 to
404af47
Compare
|
Yes that is what it looked like, I have straightened it out, but in the future just rebase to resolve any conflicts... |
GordonSmith
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#378