fix import of fancylogger with Python 3 #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fancylogger test module in Python 3 + bump version to 2.8.0
stdweird
reviewed
Jul 5, 2019
| @@ -412,7 +418,7 @@ def somefunction(self): | |||
| handler = fancylogger.logToScreen() | |||
| logger = fancylogger.getLogger(fname=False, clsname=False) | |||
| logger.warn("blabla") | |||
| print stringfile.getvalue() | |||
| print(stringfile.getvalue()) | |||
There was a problem hiding this comment.
import is there now (but this change is still needed, print 'foo' never works in Python 3, even with the import
stdweird
reviewed
Jul 5, 2019
| set -e; | ||
| export PYTHONPATH="$PWD/lib:$PYTHONPATH"; | ||
| python -c "import vsc.utils.fancylogger"; | ||
| python -c "import test.fancylogger"; |
There was a problem hiding this comment.
this does not actually test anything, so why bother?
There was a problem hiding this comment.
It saves some of the problems, makes the PR short and easy to review, etc., the tests pass as is, etc.
Baby steps.
There was a problem hiding this comment.
To clarify:
- this checks whether
vsc/utils/fancylogger.pyno longer hasSyntaxErrors; same fortest/fancylogger.py - can't run only the
fancyloggersubsuite yet, more changes are needed for that due toSyntaxErrorintest/missing.py
If you prefer, I can fix the import test/missing.py too, and see if that's enough to run the fancylogger tests with Python 3 (but it's going to blow up the PR, why not merge it first since it's easy to review right now).
|
Closing this in favor of #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baby step towards supporting Python 3, I apparently had this sitting in a branch but never opened a PR for it (I knew #282 looked familiar).
More changes are needed to actually run the
fancyloggertests, that would be the next goal I guess...