Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the env variable for csp logging #272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bhagyashree-sarawate
Copy link
Contributor

@sneharai4 @raunakkumar Please review
Added env variable to have the CSP logs as per the logLevel mentioned.
CON-2329 ,3PAR CSP should honor Helm chart logLevel

3PAR/Primera CSP is using default trace level of logging. The customer should have the option to dial down logging to match the logLevel available to them to configure in the Helm chart.

Signed-off-by: bhagyashree_sarawate <bhagyashree.sarawate@hpe.com>
@datamattsson
Copy link
Collaborator

It would also be good to set it do the default in the YAML files to let users know there's an option to tune logLevel (add to edge).

@bhagyashree-sarawate
Copy link
Contributor Author

It would also be good to set it do the default in the YAML files to let users know there's an option to tune logLevel (add to edge).

done

Signed-off-by: bhagyashree_sarawate <bhagyashree.sarawate@hpe.com>
Copy link
Collaborator

@datamattsson datamattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sneharai4 sneharai4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But let's not plan this for CSI 2.1 release as it will need log level changes in 3PAR CSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants