CON-3010 Changes for resize the filesystem for creating clone from sn… #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lothejyotsna
requested review from
raunakkumar,
suneeth51,
pavansshanbhag,
datamattsson,
dileepds and
sijeesh
as code owners
|
PRs need to be signed to be reviewed and approved. |
…apshot Signed-off-by: jyotsna-lothe <jyotsna.lothe@hpe.com>
…VC claim Signed-off-by: jyotsna-lothe <jyotsna.lothe@hpe.com>
…le system Signed-off-by: jyotsna-lothe <jyotsna.lothe@hpe.com>
Signed-off-by: jyotsna-lothe <jyotsna.lothe@hpe.com>
Signed-off-by: jyotsna-lothe <jyotsna.lothe@hpe.com>
rohit-balakrishna
approved these changes
Jan 9, 2025
|
|
||
| // If the DataSource is a VolumeSnapshot | ||
| if pvc.Spec.DataSource.Kind == "VolumeSnapshot" { | ||
| log.Infof(" Source Kind: VolumeSnapshot\n VolumeSnapshot Name: %s\n", pvc.Spec.DataSource.Name) |
There was a problem hiding this comment.
nit: is the newlines in between intentional? Might not be needed, since each log will be in a newline by default.
| return nil, | ||
| status.Error(codes.InvalidArgument, | ||
| fmt.Sprintf("Requested clone size %d is not equal to the parent volume size %d", size, existingParentVolume.Size)) | ||
| status.Error(codes.Internal, |
There was a problem hiding this comment.
Wouldnt it be better to leave the error code as InvalidArgument ? It is not an internal error, since the requested size is wrong, better to return InvalidArgument.
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2019 Hewlett Packard Enterprise Development LP | |||
| // Copyright 2019,2024 Hewlett Packard Enterprise Development LP | |||
There was a problem hiding this comment.
nit:2025, please check other files, some have 2024.
|
@lothejyotsna , please also rebase to the latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for CON 3010 - resize the filesystem when clone created from volumesnapshot is of size > parent volume