Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Add vlan tagged iscsi ports support #29

Open
Ctesias opened this issue Mar 7, 2017 · 0 comments
Open

RFE: Add vlan tagged iscsi ports support #29

Ctesias opened this issue Mar 7, 2017 · 0 comments

Comments

@Ctesias
Copy link

Ctesias commented Mar 7, 2017

When a user vlan tags iscsi ports on 3par systems this driver can't find the port information required to connect initiators and fails out. I've attached a file with the ouput of the showport and showport -iscsivlan commands from the 3par system I have under test and the cinder debug logs and error:

hp3par_client_error_iscsi_port_vlans.txt

I'm willing to write the update for this feature. I wanted to have some discussion around the way the owners would prefer to see it done. I see two options:

  1. Add a self.ssh.run('showport -iscsivlan') to the getPorts() method, massage the output into an array of port objects similar to what it gets from the api call, and append it to the members key of that object. Or,

  2. Add a hp3par_iscsi_vlans_enabled=true flag to cinder_override.conf and create tie-ins to getPorts() to only return the output of one command or the other.

I think I'd prefer 1 since it would let people use vlans without any extra work being done by the end user. I'm open to additional options as well.

wdurairaj pushed a commit to wdurairaj/python-3parclient that referenced this issue Jul 8, 2019
Merge pull request #319 from sonivi/plugin_v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant