Fix for issue #513 #581
Merged
Fix for issue #513 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added rollback to mount flow for any cleanup in case of any failure -Added validation for fsOwner
wdurairaj
reviewed
Apr 16, 2019
| undo_action['undo_func'](**undo_action['params']) | ||
| params = undo_action['params'] | ||
| if type(params) is dict: | ||
| undo_action['undo_func'](**undo_action['params']) |
There was a problem hiding this comment.
Any specific reason to identify the data type of the params and call the undo functions differently.. I'm asking due to the previous code does'nt have this kind of check ?
There was a problem hiding this comment.
i got the answer. Tuple is passed explicitly in undo_steps.append(..'params')
undo_steps.append(
{'undo_func': driver.terminate_connection,
'params': (vol, connector_info, is_snap),
wdurairaj
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added rollback for merge to undo changes when mount fails
-Added validation check for fsOwner
-Fixed PEP8 issue