Skip to content

Commit

Permalink
BC-7345 - upgrade node (#3346)
Browse files Browse the repository at this point in the history
  • Loading branch information
virgilchiriac authored Aug 16, 2024
1 parent cf2021f commit 6485835
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 9 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:
contents: read

env:
node: 18
node: 20
jobs:
unit:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -49,6 +49,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: setup node
uses: actions/setup-node@v4
with:
node-version: ${{ env.node }}
- name: npm ci
run: npm ci --prefer-offline --no-audit
- name: npm run lint
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# build stage
FROM docker.io/node:18-bullseye AS build-stage
FROM docker.io/node:20 AS build-stage

## add libraries needed for installing canvas npm package
RUN apt update && apt install -y g++ libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev;
Expand Down
11 changes: 7 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dependencies": {
"@braintree/sanitize-url": "^6.0.4",
"@ckeditor/ckeditor5-vue": "^5.1.0",
"@hpi-schul-cloud/ckeditor": "^1.0.0",
"@hpi-schul-cloud/ckeditor": "^1.1.0",
"@lumieducation/h5p-webcomponents": "^9.2.2",
"@vuelidate/core": "^2.0.3",
"@vuelidate/validators": "^2.0.4",
Expand Down Expand Up @@ -102,7 +102,7 @@
}
},
"engines": {
"node": "18",
"node": "20",
"npm": ">=9"
}
}

0 comments on commit 6485835

Please sign in to comment.