Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7960 - Move config api to tldraw server #105

Merged
merged 13 commits into from
Oct 22, 2024
Merged

BC-7960 - Move config api to tldraw server #105

merged 13 commits into from
Oct 22, 2024

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Oct 15, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Contributor

@bergatco bergatco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor point.

- Update tldraw-client-configmap.yml.j2 to use SERVER_TLDRAW_2_ENABLED instead of VITE_SERVER_TLDRAW_2_ENABLED
- Add location block in nginx.conf.template to return SERVER_TLDRAW_2_ENABLED value
- Modify api.configuration.ts to fetch SERVER_TLDRAW_2_ENABLED value from /tldraw-client-runtime.config.json in production environment
- Remove unused code related to BC-7906
Copy link

sonarcloud bot commented Oct 22, 2024

@SevenWaysDP SevenWaysDP merged commit dba0f3f into main Oct 22, 2024
58 of 59 checks passed
@SevenWaysDP SevenWaysDP deleted the BC-7960 branch October 22, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants