-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-7960 - Move config api to tldraw server #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2024
bergatco
reviewed
Oct 16, 2024
bergatco
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor point.
bergatco
approved these changes
Oct 16, 2024
1 task
- Update tldraw-client-configmap.yml.j2 to use SERVER_TLDRAW_2_ENABLED instead of VITE_SERVER_TLDRAW_2_ENABLED - Add location block in nginx.conf.template to return SERVER_TLDRAW_2_ENABLED value - Modify api.configuration.ts to fetch SERVER_TLDRAW_2_ENABLED value from /tldraw-client-runtime.config.json in production environment - Remove unused code related to BC-7906
bergatco
approved these changes
Oct 18, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-7960
BC-7960 - Move config api to tldraw server dof_app_deploy#999
BC-7960 - Move config api to tldraw server schulcloud-server#5293
BC-7960 - Move config api to tldraw server tldraw-server#23
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review