Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't discard errors during snapshot/asset loading #40

Open
MariusDoe opened this issue Nov 5, 2024 · 0 comments
Open

Don't discard errors during snapshot/asset loading #40

MariusDoe opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MariusDoe
Copy link
Collaborator

This leads to confusion because the error is treated as if the code/asset was not present, leading to apparent deletions in the change sets.

Instead, the error should simply not be caught and a file/directory exists check should be added before loading. This is enough, as mappers should be provided a commit in which they are tracked (which should imply that the code/asset is present) or an empty commit (which cannot contain any other mapped file).

@MariusDoe MariusDoe added the bug Something isn't working label Nov 5, 2024
MariusDoe added a commit that referenced this issue Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant