Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for variants in dynamic ui methods #128

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

JoeAtHPI
Copy link
Collaborator

@JoeAtHPI JoeAtHPI commented Nov 7, 2023

Previously, watched objects were static. The variants were only selected differently once when creating Exploriants. However, for methods such as step, this results in the same behavior for every permutation. This MR saves permutations in Exploriants and asks them when a variant is dissolved
image

@JoeAtHPI JoeAtHPI added enhancement New feature or request Exploriants labels Nov 7, 2023
@JoeAtHPI JoeAtHPI requested a review from tom95 November 7, 2023 12:29
@JoeAtHPI JoeAtHPI self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6784482122

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 6747433687: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@tom95 tom95 merged commit 677d513 into master Nov 8, 2023
2 checks passed
JoeAtHPI pushed a commit that referenced this pull request Nov 21, 2023
Adds support for variants in dynamic ui methods

(cherry-picked from commit 677d513)
@JoeAtHPI JoeAtHPI deleted the feature/dynamic-variants branch November 24, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Exploriants
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants