-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructional prompt after loading project #469
Conversation
Nice idea! Would it be helpful to print a message to stdout, too? When I'm running something from the terminal, I'll often expect the terminal to print any message when I'm required to take some action. |
I don't really see the reason for doing this. |
I was thinking of several modifications that can occur during test execution and break any part of the UI. E.g. a test could install a different ToolSet and forget to reset it or modify the visual appearance in some way that makes the UIManager prompt invisible. In this case, debugging would be easier if a hint was printed into the terminal, too. Another reason is that the test execution can take a long time and while you are working in another program, the VM usually does not inform you when a dialog window appears. In contrast, many terminals can notify the user if a new portion of output was printed to a background terminal instance (for example, felixse/FluentTerminal#60 or microsoft/terminal#7955). A third use case would be UI tests that disallow you to interact with the image which could have side effects on the tests. In such situations, I use to minimize the VM window while the tests are executing, so I would not see the VM prompt, again, but only any terminal message. Do you see what I mean? :-) |
Hm, I just realized that the same claim could also be made for all the progress bars that appear during the image setup/project loading stage. We could also duplicate all kinds of outputs in an extra ToolSet implementation and avoid any extra logic in this PR. In any case, it was not my intention to block this PR. :-) |
Okay, you bring up some fair points. Most of them focus on the There actually is (or was at some point) a UIManager that uses the Command-line instead of Squeak GUI elements, so that one could be installed as well. |
Ah, I missed that, fair point. There should be a rare number of installation scripts that corrupt the overall UI appearance.
Afaik there is no such implementation for Squeak, but one for Pharo. But a tl;dr: Please pardon the interruption and go ahead with your changes! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this!
I've changed SmalltalkCI>>#promptToProceedImpl
so that proceeds by default, reverted redundant changes to various metadata files, and fixed the author initials.
I'll merge this once CI has passed again...
Closes #456