forked from open-mpi/ompi
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads squash rebase #6
Open
hppritcha
wants to merge
29
commits into
hppritcha:main
Choose a base branch
from
npe9:threads-squash-rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a8148b2
git up to HEAD
npe9 e30bd1a
add new wait_sync to pthreads mca
npe9 ed196ff
threads: improve pthreads comp configury
hppritcha 7d3f6b9
small fixes to get the libevent thread working
npe9 db7591d
threads: add some copyrights
hppritcha cd586f5
threads: add some missed copyrights
hppritcha 5b4c92b
threads: minor reformatting
hppritcha 95d5cd0
readd stub header
npe9 a8b7820
fix thread_usage.h
npe9 770ae4b
get rid of null object leftovers
npe9 c30c6a5
reorgnize mutex header structure
npe9 4a9074e
sync_wait_mt no longer necessary
npe9 95c391f
add threading framework to opal_init
npe9 8116bdc
mca/threads: clean up
shintaro-iwasaki 6514506
Merge pull request #2 from shintaro-iwasaki/threads-squash-rebase
npe9 df9ed9b
mca/threads: make a wrapper for cond.
shintaro-iwasaki e574970
mca/threads: fix Pthreads mutex implementation.
shintaro-iwasaki d498325
Merge pull request #4 from shintaro-iwasaki/threads-squash-rebase-pth
npe9 04ebf88
threads: rework configury
hppritcha 026bb89
threads: remove workaround for mpi wrappers
hppritcha f203d57
config: fix thread configury
shintaro-iwasaki de2b838
config: implement Argobots check
shintaro-iwasaki c55be05
mca/threads: implement Argobots threading layer
shintaro-iwasaki fc5c7c5
[DON'T MERGE] libevent: reduce the poll interval.
shintaro-iwasaki 9f26479
[DON'T MERGE] Fix tests to run make check.
shintaro-iwasaki e5791f9
Merge pull request #5 from shintaro-iwasaki/threads-squash-rebase-con…
hppritcha c7e4269
Merge pull request #3 from shintaro-iwasaki/threads-squash-rebase
hppritcha 21b944c
threads/argobots: cast pointers for atomic functions
shintaro-iwasaki 0e2245e
Merge pull request #6 from shintaro-iwasaki/thread-squash-rebase-abt-…
npe9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# | ||
# Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana | ||
# University Research and Technology | ||
# Corporation. All rights reserved. | ||
# Copyright (c) 2004-2005 The University of Tennessee and The University | ||
# of Tennessee Research Foundation. All rights | ||
# reserved. | ||
# Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, | ||
# University of Stuttgart. All rights reserved. | ||
# Copyright (c) 2004-2005 The Regents of the University of California. | ||
# All rights reserved. | ||
# Copyright (c) 2010 Cisco Systems, Inc. All rights reserved. | ||
# Copyright (c) 2019 Sandia National Laboratories. All rights reserved. | ||
# $COPYRIGHT$ | ||
# | ||
# Additional copyrights may follow | ||
# | ||
# $HEADER$ | ||
# | ||
|
||
# main library setup | ||
noinst_LTLIBRARIES = libmca_threads.la | ||
libmca_threads_la_SOURCES = | ||
|
||
# local files | ||
headers = threads.h | ||
nodist_headers = | ||
libmca_threads_la_SOURCES += $(headers) | ||
|
||
# Conditionally install the header files | ||
if WANT_INSTALL_HEADERS | ||
opaldir = $(opalincludedir)/$(subdir) | ||
nobase_opal_HEADERS = $(headers) | ||
nobase_nodist_opal_HEADERS = $(nodist_headers) | ||
endif | ||
|
||
include base/Makefile.am | ||
|
||
distclean-local: | ||
rm -f base/static-components.h |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# | ||
# Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana | ||
# University Research and Technology | ||
# Corporation. All rights reserved. | ||
# Copyright (c) 2004-2005 The University of Tennessee and The University | ||
# of Tennessee Research Foundation. All rights | ||
# reserved. | ||
# Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, | ||
# University of Stuttgart. All rights reserved. | ||
# Copyright (c) 2004-2005 The Regents of the University of California. | ||
# All rights reserved. | ||
# Copyright (c) 2019 Sandia National Laboratories. All rights reserved. | ||
# | ||
# $COPYRIGHT$ | ||
# | ||
# Additional copyrights may follow | ||
# | ||
# $HEADER$ | ||
# | ||
|
||
headers += \ | ||
base/base.h \ | ||
base/threads_base_null.h | ||
|
||
libmca_threads_la_SOURCES += \ | ||
base/threads_base_open.c |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana | ||
* University Research and Technology | ||
* Corporation. All rights reserved. | ||
* Copyright (c) 2004-2014 The University of Tennessee and The University | ||
* of Tennessee Research Foundation. All rights | ||
* reserved. | ||
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, | ||
* University of Stuttgart. All rights reserved. | ||
* Copyright (c) 2004-2005 The Regents of the University of California. | ||
* All rights reserved. | ||
* Copyright (c) 2014 Cisco Systems, Inc. All rights reserved. | ||
* Copyright (c) 2019 Sandia National Laboratories. All rights reserved. | ||
* | ||
* $COPYRIGHT$ | ||
* | ||
* Additional copyrights may follow | ||
* | ||
* $HEADER$ | ||
* | ||
*/ | ||
|
||
#ifndef OPAL_THREADS_BASE_H | ||
#define OPAL_THREADS_BASE_H | ||
|
||
#include "opal_config.h" | ||
#include "opal/mca/base/mca_base_framework.h" | ||
#include "opal/mca/threads/threads.h" | ||
|
||
|
||
/* | ||
* Global functions for MCA overall threads open and close | ||
*/ | ||
|
||
BEGIN_C_DECLS | ||
|
||
/** | ||
* Framework structure declaration | ||
*/ | ||
OPAL_DECLSPEC extern mca_base_framework_t opal_threads_base_framework; | ||
|
||
END_C_DECLS | ||
|
||
/* include implementation to call */ | ||
#include MCA_threads_IMPLEMENTATION_HEADER | ||
|
||
#endif /* OPAL_BASE_THREADS_H */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# | ||
# owner/status file | ||
# owner: institution that is responsible for this package | ||
# status: e.g. active, maintenance, unmaintained | ||
# | ||
owner: SNL | ||
status: maintenance |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana | ||
* University Research and Technology | ||
* Corporation. All rights reserved. | ||
* Copyright (c) 2004-2005 The University of Tennessee and The University | ||
* of Tennessee Research Foundation. All rights | ||
* reserved. | ||
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, | ||
* University of Stuttgart. All rights reserved. | ||
* Copyright (c) 2004-2005 The Regents of the University of California. | ||
* All rights reserved. | ||
* Copyright (c) 2019 Sandia National Laboratories. All rights reserved. | ||
* $COPYRIGHT$ | ||
* | ||
* Additional copyrights may follow | ||
* | ||
* $HEADER$ | ||
*/ | ||
|
||
#ifndef OPAL_MCA_TIMER_BASE_TIMER_BASE_NULL_H | ||
#define OPAL_MCA_TIMER_BASE_TIMER_BASE_NULL_H | ||
|
||
int opal_condition_t_class; | ||
int opal_mutex_t_class; | ||
int opal_recursive_mutex_t_class; | ||
|
||
int opal_thread_join(opal_thread_t *t, void **thr_return) | ||
{ | ||
return 0; | ||
} | ||
|
||
void opal_thread_set_main() | ||
{ | ||
return 0; | ||
} | ||
int opal_thread_start(opal_thread_t *t) | ||
{ | ||
return 0; | ||
} | ||
|
||
int *opal_thread_t_class = NULL; | ||
|
||
int opal_tsd_key_create(opal_tsd_key_t *key, opal_tsd_destructor_t destructor) | ||
{ | ||
return 0; | ||
} | ||
|
||
int opal_uses_threads = 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really still use this file? Maybe not include this in the final PR? |
||
|
||
int opal_tsd_keys_destruct() | ||
{ | ||
return 0; | ||
} | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana | ||
* University Research and Technology | ||
* Corporation. All rights reserved. | ||
* Copyright (c) 2004-2014 The University of Tennessee and The University | ||
* of Tennessee Research Foundation. All rights | ||
* reserved. | ||
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, | ||
* University of Stuttgart. All rights reserved. | ||
* Copyright (c) 2004-2005 The Regents of the University of California. | ||
* All rights reserved. | ||
* Copyright (c) 2014 Cisco Systems, Inc. All rights reserved. | ||
* Copyright (c) 2019 Sandia National Laboratories. All rights reserved. | ||
* | ||
* $COPYRIGHT$ | ||
* | ||
* Additional copyrights may follow | ||
* | ||
* $HEADER$ | ||
*/ | ||
|
||
|
||
#include "opal_config.h" | ||
|
||
#include "opal/constants.h" | ||
#include "opal/mca/threads/base/base.h" | ||
|
||
|
||
/* | ||
* The following file was created by configure. It contains extern | ||
* statements and the definition of an array of pointers to each | ||
* component's public mca_base_component_t struct. | ||
*/ | ||
#include "opal/mca/threads/base/static-components.h" | ||
|
||
static int mca_threads_base_register(mca_base_register_flag_t flags) | ||
{ | ||
// Do I need to register anything here? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is where you'd define base MCA parameters for the threads component |
||
return OPAL_SUCCESS; | ||
} | ||
|
||
/* | ||
* Globals | ||
*/ | ||
/* Use default register/open/close functions */ | ||
MCA_BASE_FRAMEWORK_DECLARE(opal, threads, "OPAL OS threads", mca_threads_base_register, NULL, NULL, | ||
mca_threads_base_static_components, 0); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to set these compiler flags now in the threads framework in the various components, we may need to do something special here. We think we need to rework OPAL_CONFIG_THREADS to be more agnostic about type of threads. TODO: @hppritcha will enhance OPAL_CONFIG_THREADS