-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting example for the documentation #246
Conversation
This avoids package autodetection from the wrong directory.
- remove HEAD_INIT - remove "m_" name prefixes
…nto feature/porting-example
Ready for review! |
I will be hosting a short session next week for an internal company (Quansight) meetup. Is there a chance to get this reviewed so I can use it? |
Since it passes tests, maybe we can merge after a cursory review and then fix-up any inaccuracies later |
Sure, sorry, I just missed that it is ready for review. Will do the review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice example, thank you @hodgestar .
As announced, I'll rebase your branch on master and resolve the conflicts (if you don't mind) since it is mostly due to my changes.
Thanks @hodgestar and @fangerer. If there are problems I missed, they can be touched up in subsequent PRs. I think this will really help new users understand more about HPy. |
The aim is to document the following porting steps:
Todo:
some lightweight tooling for keeping the steps up to date(it turns out showing the diffs is not that useful)The built documentation for this PR can be viewed here: https://docs.hpyproject.org/en/feature-porting-example/porting-example/