Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config should be stored in a sensible place, not CWD #117

Open
SpiritQuaddicted opened this issue Jan 26, 2019 · 6 comments
Open

Config should be stored in a sensible place, not CWD #117

SpiritQuaddicted opened this issue Jan 26, 2019 · 6 comments

Comments

@SpiritQuaddicted
Copy link
Collaborator

The config.properties is stored in the current working directory, not in the Quake directory or next to the quakeinjector.jar.

We should either store it in the Quake directory (with a better filename) or whatever place the operating system wants configs to be store in.

@SpiritQuaddicted
Copy link
Collaborator Author

@WRFitch
Copy link
Contributor

WRFitch commented Nov 12, 2021

+1 for this. Storing it next to quakeinjector.jar would be preferable since it's configuring that application, rather than the quake binary.

@SpiritQuaddicted
Copy link
Collaborator Author

Hm, I much prefer using the OS' standard place to store the stuff, not sure why I suggested that other option at all when I posted this. The quakeinjector.jar is pretty much the executable which the user could store anywhere and I think it would be nice to not force the executable to the data and vice-versa. Maybe a user supplied local configuration in the same directory as the .jar could override the "nicely stored" one though?

@demoth
Copy link

demoth commented Jul 18, 2022

I would suggest to use a common way and put the configs to user home directory - like ~/.quakeinjector for unix systems (similar thing exists for windows)

@SpiritQuaddicted
Copy link
Collaborator Author

Best would be ~/.config/QuakeInjector/ on Linux. No idea what MacOS uses. Windows should be AppData/Roaming/QuakeInjector/ or AppData/Local/QuakeInjector/ I presume although https://docs.microsoft.com/en-us/windows/apps/design/app-settings/store-and-retrieve-app-data says that this is meant for volatile data.

I have a very strong preference for

Maybe a user supplied local configuration in the same directory as the .jar could override the "nicely stored" one though?

@hrehfeld
Copy link
Owner

hrehfeld commented Jul 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants