-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config should be stored in a sensible place, not CWD #117
Comments
+1 for this. Storing it next to quakeinjector.jar would be preferable since it's configuring that application, rather than the quake binary. |
Hm, I much prefer using the OS' standard place to store the stuff, not sure why I suggested that other option at all when I posted this. The quakeinjector.jar is pretty much the executable which the user could store anywhere and I think it would be nice to not force the executable to the data and vice-versa. Maybe a user supplied local configuration in the same directory as the .jar could override the "nicely stored" one though? |
I would suggest to use a common way and put the configs to user home directory - like |
Best would be ~/.config/QuakeInjector/ on Linux. No idea what MacOS uses. Windows should be AppData/Roaming/QuakeInjector/ or AppData/Local/QuakeInjector/ I presume although https://docs.microsoft.com/en-us/windows/apps/design/app-settings/store-and-retrieve-app-data says that this is meant for volatile data. I have a very strong preference for
|
Linux: https://wiki.archlinux.org/title/XDG_Base_Directory
Xdg config dir specifically
19 Jul 2022 10:01:53 SpiritQuaddicted ***@***.***>:
… Best would be ~/.config/QuakeInjector/ on Linux. No idea what MacOS uses. Windows should be AppData/Roaming/QuakeInjector/ or AppData/Local/QuakeInjector/ I presume although https://docs.microsoft.com/en-us/windows/apps/design/app-settings/store-and-retrieve-app-data says that this is meant for volatile data.
I have a very strong preference for
Maybe a user supplied local configuration in the same directory as the .jar could override the "nicely stored" one though?
—
Reply to this email directly, view it on GitHub[#117 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAATX55IBWJPBULKOVYVUVDVUZOGNANCNFSM4GSRQZ2Q].
You are receiving this because you are subscribed to this thread.[Tracking image][https://github.com/notifications/beacon/AAATX53L35FSBQNYOJZGY2TVUZOGNA5CNFSM4GSRQZ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI3NJD4I.gif]
|
The config.properties is stored in the current working directory, not in the Quake directory or next to the quakeinjector.jar.
We should either store it in the Quake directory (with a better filename) or whatever place the operating system wants configs to be store in.
The text was updated successfully, but these errors were encountered: