Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to criterion for benchmarking #25

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Conversation

danieleades
Copy link
Contributor

migrates to criterion, a much more full-featured benchmarking harness.

Among other things, criterion provides

  • confidence intervals for benchmarking results
  • easy comparison between branches
  • HTML reports (optionally)

@danieleades
Copy link
Contributor Author

looks like landing this requires either bumping the MSRV or waiting until this gets merged - rust-lang/cargo#5133

@danieleades danieleades marked this pull request as draft June 29, 2023 04:46
@danieleades
Copy link
Contributor Author

@hrektts i've 'fixed' this PR by bumping the MSRV to 1.60.0. This also means the edition can be bumped to 2021.

@danieleades danieleades marked this pull request as ready for review June 29, 2023 23:02
@hrektts hrektts merged commit 76630a6 into hrektts:master Jun 29, 2023
5 checks passed
@danieleades danieleades deleted the criterion branch June 29, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants