Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Mobile Optimisations #191

Merged
merged 7 commits into from
Jan 30, 2022
Merged

Further Mobile Optimisations #191

merged 7 commits into from
Jan 30, 2022

Conversation

JamsRepos
Copy link
Contributor

This PR includes more mobile optimisations primarily for the modals on mobile as they squish too much, also a little converting to more Tailwind less style-sheets.

@netlify
Copy link

netlify bot commented Jan 28, 2022

✔️ Deploy Preview for jfa-go canceled.

🔨 Explore the source changes: ecbff16

🔍 Inspect the deploy log: https://app.netlify.com/sites/jfa-go/deploys/61f6bc197d0e6c0007fea44a

@JamsRepos
Copy link
Contributor Author

@hrfee not sure what this compile error is related to as I'm on my phone, care to take a look? Works fine on a local instance.

@hrfee
Copy link
Owner

hrfee commented Jan 30, 2022

Accidentally just pushed to your fork lmao, but the jfa-go.com build was already broken. Compilation worked fine, and my commit should get rid of the errors.

@hrfee
Copy link
Owner

hrfee commented Jan 30, 2022

This looks great, also makes me realize i need to test on my phone more often 😂. One thing i did notice is that there's no longer a modal opening animation. I wasn't a big fan of the old one anyway but do you think a quick fade-in like there is for closing would look alright?

@JamsRepos
Copy link
Contributor Author

I've never noticed one, where was it supposed to be? One can be added with the transition class and a duration-500 or something, I'm not on my PC at the minute to test.

now a simple fade-in/fade-out, which is part of tailwind.config.js
rather than modal.css.
@hrfee hrfee merged commit e814af1 into hrfee:main Jan 30, 2022
@hrfee
Copy link
Owner

hrfee commented Jan 30, 2022

I've added a simple fade-in and fade-out which uses animate-fade-in and animate-fade-out classes. Everything else looks good so i'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants