fix: forward mouse events inside layout #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After refactoring layout, the if statements were removed in favor of a single match. This changed the control flow a bit, breaking mouse event propagation.
|
I'm very sorry that this made its way upstream. I have no clue how I didn't find this when testing everything. I only recently upgraded to a git build which did include this bug (it wasn't in v0.13.2), so that's how I noticed it. I also removed the 'implicit' I hope this is the last bug from the refactor 🤞 |
|
No problem, it happens! :) Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring layout, the if statements were removed in favor of a single match. This changed the control flow a bit, breaking mouse event propagation.