Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfg fix for linux #1451

Merged
merged 1 commit into from
May 7, 2024
Merged

cfg fix for linux #1451

merged 1 commit into from
May 7, 2024

Conversation

aragonnetje6
Copy link
Contributor

Describe your changes

changed cfg!(linux) to cfg!(target_os = "linux") since the former is not actually valid, but produces no bug. this wasn't causing any problem that i know of, but if the code is in here it should probably do what it says, or be removed

Issue ticket number and link

no issue created, just saw a warning when installing from master (though this warning is not showing up again for some reason)

Checklist before requesting a review

  • Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
  • Changelog was updated with relevant user-facing changes (eg. not dependency updates,
    not performance improvements, etc.)

@ThomasFrans
Copy link
Contributor

Oops, I should have read the documentation of the cfg!() macro better 😬
Nice find. I wonder why this every worked for me as I assume cfg!(linux) just doesn't do anything, but if I remember correctly the code did work on FreeBSD for example. I installed it in a VM specifically to test this code. Maybe I'm just misremembering 🤔

Copy link
Owner

@hrkfdn hrkfdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch indeed!

@hrkfdn hrkfdn merged commit 2db47e3 into hrkfdn:main May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants