fix(cover): init variables with value of 1 #1533
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the Change log? |
|
I've never used a change log before. Isn't that only whenever there is a new version to be released? |
HurricanePootis
force-pushed
the
cover
branch
from
5f13c3b
to
11752fd
Compare
|
Changelog was updated |
|
I just want to report that with this patch, ncspot runs fine but crashes when I try to change to the cover tab with F8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Initializes
rowsandcolswith a value of 1 instead of 0 to avoid dividing by zero.Issue ticket number and link
#1528
Checklist before requesting a review
not performance improvements, etc.)