Optimize HashPMap.get and other operations: do not create unnecessary iterator instances #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve binary names of iterators and entry sets. For example, [here](http://stackoverflow.com/questions/34214290/kotlin-massive-amounts-of-conspstack-how-can-i-avoid/34214718#34214718) it's not obvious from the class name what kind of objects are being allocated. `Itr` and `EntrySet` (names are used by JDK) are hopefully much more clear
udalov
added a commit
to JetBrains/kotlin
that referenced
this pull request
Aug 17, 2016
Don't create unnecessary iterator every time in HashPMap.get (see hrldcpr/pcollections#41). Also fix a warning and remove misleading comment
udalov
added a commit
to JetBrains/kotlin
that referenced
this pull request
Aug 26, 2016
Don't create unnecessary iterator every time in HashPMap.get (see hrldcpr/pcollections#41). Also fix a warning and remove misleading comment
udalov
added a commit
to JetBrains/kotlin
that referenced
this pull request
Sep 5, 2016
Don't create unnecessary iterator every time in HashPMap.get (see hrldcpr/pcollections#41). Also fix a warning and remove misleading comment
udalov
added a commit
to JetBrains/kotlin
that referenced
this pull request
Sep 5, 2016
Don't create unnecessary iterator every time in HashPMap.get (see hrldcpr/pcollections#41). Also fix a warning and remove misleading comment
udalov
added a commit
to JetBrains/kotlin
that referenced
this pull request
Sep 5, 2016
Don't create unnecessary iterator every time in HashPMap.get (see hrldcpr/pcollections#41). Also fix a warning and remove misleading comment (cherry picked from commit f4a1aa6)
ilya-g
reviewed
Feb 19, 2017
hrldcpr
force-pushed
the
master
branch
2 times, most recently
from
1daafae to
c9c4c3d
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use PCollections as an internal cache for classes in Kotlin reflection library (proof) and have recently found a problem:
HashPMap.getseems to create lots of unnecessaryConsPStack$1objects, which areConsPStackiterators, even on simplegetaccess! Here's the original report (never mind my misleading answer there):http://stackoverflow.com/questions/34214290/kotlin-massive-amounts-of-conspstack-how-can-i-avoid/34214718#34214718
This pull request optimizes iteration over
ConsPStackinsideHashPMap. First, I've made sure onlyConsPStackis used as thePSequenceimplementation by making the types of parameters and fields more specific. In the second commit, I've replaced the for loop with the manual iteration over theConsPStackinstance. In the last commit, I've made anonymous classes inner with meaningful names, so that one will observe a more insightfulConsPStack$Itrin the stack trace instead ofConsPStack$1.