Rename Optuna.Storage.IStorage to IOptunaStorage

hrntsm · Feb 20, 2024 · c674cfe · c674cfe
1 parent 100efb0
commit c674cfe
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/Optuna/Storage/IStorage.cs → Optuna/Storage/IOptunaStorage.cs b/Optuna/Storage/IStorage.cs → Optuna/Storage/IOptunaStorage.cs
@@ -5,7 +5,7 @@
 
 namespace Optuna.Storage
 {
-    public interface IStorage
+    public interface IOptunaStorage
     {
         // Basic study manipulation
         int CreateNewStudy(StudyDirection[] studyDirections, string studyName);

diff --git a/Optuna/Storage/Journal/Storage.cs b/Optuna/Storage/Journal/Storage.cs
@@ -10,7 +10,7 @@
 
 namespace Optuna.Storage.Journal
 {
-    public class JournalStorage : IStorage
+    public class JournalStorage : IOptunaStorage
     {
         private readonly Dictionary<int, Study.Study> _studies = new Dictionary<int, Study.Study>();
         private int _nextStudyId;

diff --git a/Optuna/Storage/RDB/Storage.cs b/Optuna/Storage/RDB/Storage.cs
@@ -12,7 +12,7 @@
 
 namespace Optuna.Storage.RDB
 {
-    public class SqliteStorage : IStorage
+    public class SqliteStorage : IOptunaStorage
     {
         private readonly Dictionary<int, Study.Study> _studies = new Dictionary<int, Study.Study>();
         private readonly SQLiteConnectionStringBuilder _sqliteConnection;

diff --git a/Optuna/Study/Study.cs b/Optuna/Study/Study.cs
@@ -18,9 +18,9 @@ public class Study
         public int StudyId { get; }
 
         private readonly bool _isMultiObjective;
-        private readonly IStorage _storage;
+        private readonly IOptunaStorage _storage;
 
-        public Study(IStorage storage, int studyID, string studyName, StudyDirection[] directions)
+        public Study(IOptunaStorage storage, int studyID, string studyName, StudyDirection[] directions)
         {
             StudyId = studyID;
             _storage = storage;
@@ -95,7 +95,7 @@ private Trial.Trial[] GetBestTrials()
             return MultiObjective.GetParetoFrontTrials(Trials, Directions);
         }
 
-        public static StudySummary[] GetAllStudySummaries(IStorage storage)
+        public static StudySummary[] GetAllStudySummaries(IOptunaStorage storage)
         {
             Study[] studies = storage.GetAllStudies();
             var studySummaries = new StudySummary[studies.Length];

diff --git a/OptunaTests/Storage/StorageSameBevaviorTests.cs b/OptunaTests/Storage/StorageSameBevaviorTests.cs
@@ -12,7 +12,7 @@ public class StorageSameBehaviorTests
         [InlineData(@"TestFile/journal.log", "log")]
         public void StorageLoadTest(string path, string type)
         {
-            IStorage storage;
+            IOptunaStorage storage;
             int offset = 0; // journal starts from 0
 
             if (type == "sqlite")

diff --git a/Tunny.Core/Settings/Storage.cs b/Tunny.Core/Settings/Storage.cs
@@ -1,6 +1,7 @@
 using System;
 using System.IO;
 
+using Optuna.Storage;
 using Optuna.Study;
 
 using Python.Runtime;
@@ -131,7 +132,7 @@ private dynamic CreateArtifactBackendProcess()
         public Study[] GetAllStudies()
         {
             TLog.MethodStart();
-            Optuna.Storage.IStorage storage;
+            IOptunaStorage storage;
             switch (Type)
             {
                 case StorageType.Sqlite: