Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add sqlite handler in optuna csproj #244

Merged
merged 9 commits into from
Feb 18, 2024

Conversation

hrntsm
Copy link
Owner

@hrntsm hrntsm commented Feb 18, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Add class for handling SQLite in optuna.csproj.

@hrntsm hrntsm self-assigned this Feb 18, 2024
@hrntsm hrntsm added the enhancement New feature or request label Feb 18, 2024
@hrntsm hrntsm changed the base branch from main to develop February 18, 2024 04:46
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (c252fa3) 53.51% compared to head (c841137) 70.54%.
Report is 3 commits behind head on develop.

Files Patch % Lines
Optuna/Storage/RDB/Storage.cs 86.52% 52 Missing and 7 partials ⚠️
Optuna/Study/MultiObjective.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #244       +/-   ##
============================================
+ Coverage    53.51%   70.54%   +17.03%     
============================================
  Files            7        7               
  Lines          598     1015      +417     
  Branches        51       78       +27     
============================================
+ Hits           320      716      +396     
- Misses         261      275       +14     
- Partials        17       24        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Feb 18, 2024

Code Climate has analyzed commit c841137 and detected 21 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 9
Duplication 12

View more on Code Climate.

@hrntsm hrntsm merged commit e19dbe8 into develop Feb 18, 2024
7 of 9 checks passed
@hrntsm hrntsm deleted the feature/add-sqlite-handler-in-optuna-csproj branch February 18, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant