Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Optuna-Dashboard issue with artifact directory containing spaces #294

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix Optuna-Dashboard issue with artifact directory containing spaces #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Please see [here](https://github.com/hrntsm/Tunny/releases) for the data release
- Add check and kill the process method
- Rhino7 and Rhino8 compatibility
- There was a difference in specifications between Rhino 7 (net48) and Rhino 8 (net7) when serializing its Version to JSON for saving settings.
- Optuna-Dashboard doesn't work when artifact-dir contains space.

## [v0.11.1] -2024-05-10

Expand Down
2 changes: 1 addition & 1 deletion Optuna/Dashboard/Handler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
public void Run()
{
KillExistDashboardProcess();
string argument = $"{_storage} --host {_host} --port {_port} --artifact-dir {_artifactDir}";
string argument = $"{_storage} --host {_host} --port {_port} --artifact-dir \"{_artifactDir}\"";

Check warning on line 58 in Optuna/Dashboard/Handler.cs

View check run for this annotation

Codecov / codecov/patch

Optuna/Dashboard/Handler.cs#L58 

Added line #L58 was not covered by tests

var dashboard = new Process();
dashboard.StartInfo.FileName = _dashboardPath;
Expand Down
Loading