Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pruner #331

Merged
merged 24 commits into from
Oct 13, 2024
Merged

Add Pruner #331

merged 24 commits into from
Oct 13, 2024

Conversation

hrntsm
Copy link
Owner

@hrntsm hrntsm commented Oct 12, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Add Pruner
  • Add quit.fishing setting

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 26.27737% with 202 lines in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (7748ead) to head (e0a6ec8).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
Tunny.Core/Settings/Pruner.cs 14.91% 97 Missing ⚠️
Optuna/Pruner/PercentilePruner.cs 32.00% 17 Missing ⚠️
Optuna/Pruner/ThresholdPruner.cs 31.81% 15 Missing ⚠️
Optuna/Pruner/HyperbandPruner.cs 33.33% 14 Missing ⚠️
Optuna/Pruner/MedianPruner.cs 33.33% 14 Missing ⚠️
Optuna/Pruner/SuccessiveHalvingPruner.cs 33.33% 14 Missing ⚠️
Optuna/Pruner/PatientPruner.cs 31.57% 13 Missing ⚠️
Optuna/Pruner/WilcoxonPruner.cs 31.25% 11 Missing ⚠️
Optuna/Pruner/NopPruner.cs 0.00% 3 Missing ⚠️
Optuna/Study/Study.cs 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #331      +/-   ##
===========================================
- Coverage    45.80%   43.75%   -2.06%     
===========================================
  Files           45       55      +10     
  Lines         2314     2587     +273     
  Branches       225      251      +26     
===========================================
+ Hits          1060     1132      +72     
- Misses        1223     1424     +201     
  Partials        31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Oct 13, 2024

Code Climate has analyzed commit e0a6ec8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@hrntsm hrntsm merged commit d616513 into develop Oct 13, 2024
4 of 6 checks passed
@hrntsm hrntsm deleted the feature/add-rhinocompute-gh branch October 13, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant