Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add release workflow to publish new tags to LuaRocks #1431

Merged
merged 4 commits into from
May 1, 2023

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Feb 10, 2023

NOTE: This requires a LUAROCKS_API_KEY.
See also the luarocks-tag-release README.

@mrcjkb mrcjkb force-pushed the luarocks-tag-release branch from 220545b to e8039da Compare February 10, 2023 14:05
@hrsh7th
Copy link
Owner

hrsh7th commented Feb 11, 2023

Thank you for your cooperation.

I would like to know the benefits of registering nvim-cmp with LuaRocks.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Feb 11, 2023

Thank you for your cooperation.

I would like to know the benefits of registering nvim-cmp with LuaRocks.

Oh, sorry I forgot to update the description.
I wrote a blog post yesterday that should contain all the info :)

@hrsh7th
Copy link
Owner

hrsh7th commented Feb 11, 2023

Thank you for the detailed information.

I agree with that story, and it seems fine to register nvim-cmp with LuaRocks for the time being.

So it's safe to merge.
I will check the operation and the code.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Feb 11, 2023

Thanks for supporting this.

@hrsh7th hrsh7th merged commit c3f7c54 into hrsh7th:main May 1, 2023
@mrcjkb mrcjkb deleted the luarocks-tag-release branch May 1, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants