feat: Refactor compare.scopes #2007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On nvim-treesitter `main` the methods used in compare.scopes seem to error instead of silently failing, this implements a rudimentary fix for those using `main` (which are guaranteed to be using nvim 0.10+).
pynappo
force-pushed
the
patch-nvim-ts-main
branch
from
68179db
to
a6b69a8
Compare
pynappo
force-pushed
the
patch-nvim-ts-main
branch
from
8cc9771
to
43b2d6d
Compare
pynappo
force-pushed
the
patch-nvim-ts-main
branch
from
43b2d6d
to
a6be39a
Compare
pynappo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nvim-treesitter
main, some of the methods used in cmp'scompare.scopesnow error instead of returning an empty table when no tree-sitter parser exists (specifically,locals.get_*). This implements a basic fix.Leaving it as a draft because:compare.scopesinstead ofvim.b?pcallthe affectedlocals.get_*methods?Edit: This PR has also turned into an overhaul of
compare.scopes:definitionsonce perupdate()update, leading to more expected sorting (previously, nothing ever got removed or modified once it was put into thescopes_map).edit2: I can also revert the renaming of the variables if you'd like, I just did it out of my preference when I was changing the function around