fix: don't blow up when nvim_buf_get_lines()
returns Blobs
#2050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some LSP servers may return binary garbage and
nvim_buf_get_lines()
will return aBlob
instead of aString
in those cases.I added some
print(vim.inspect())
debugging inentry.get_documentation()
to prove that by the time the text passes through there, it's already garbage.Here's an excerpt from a sample line returned by
nvim_buf_get_lines()
, as rendered byvim.inspect()
:(etc)
Now, this looks like an LSP bug to me, but I think we shouldn't allow buggy LSP output to crash nvim-cmp. "Be conservative in what you send, be liberal in what you accept" and all that.
So, degrade by coercing any
Blob
we see into aString
before passing it tostrdisplaywidth()
.Closes: #820