Save menu hides text

[tilkinsc]

What happens?

The text is hidden behind the gui from ppsspp

What should happen?

The save state text and image should be raised, or at least the text

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Windows, vulkan, gtx 1080ti, 1.7.5 dev 345 g12e54baeb

[hrydgard]

Yup, our layout can't handle quite that much text it seems.

[tilkinsc]

Oh yeah and these are official fonts rather than PPSSPP fonts from my fat psp-1000

[hrydgard]

Yeah, it doesn't matter in this case though. Since the save menus are normally provided by the PSP OS, we've had to simulate them, and we're always using our own font in this case. These simulated menus have some deficiencies, like this one. Any chance you could get a screenshot of what the layout looks like with this save data on a real PSP?

[unknownbrackets]

It looks like this on a real PSP:

The same in PPSSPP:

So clearly, it ellipsizes the text, but we also have much higher leading / line height, while a thinner, more slim font face. That said, I think it's clear that the intent in this case was to expose all the levels to the user and that it doesn't is probably just a shortcoming in the UI.

(I don't know why the sizes are displayed differently, it's possible I have cruft in that save directory on one or the other...)

-[Unknown]

[hrydgard]

I suppose the easiest fix would be to just check if the text layouts too big, and in that case scale it down...

Not prioritizing it for 1.8.0 though myself.

[tilkinsc]

Do you feel like we should keep a consistent style with the real PSP?

[hrydgard]

I think it should be roughly similar, but where we can make minor improvements there's no reason not to.

[tilkinsc]

Where exactly is the code for the positioning? I could make a temp hack for myself.

[hrydgard]

The various system UIs are in Core/Dialog/PSP*.cpp. It uses an internal drawing library that generates PSP GPU commands that are fed to our GPU backend, to integrate cleanly, called PPGe which resides in Core/Util/PPGeDraw.*.

[tilkinsc]

I wonder if implementing a scrolling text area would solve this problem if the text > y of the screen. Controlled by the joystick?

This area should contain only the text and not the title or image. That would be an awesome solution, as it would fit the style (and thus of a mechanic of the psp) while improving functionality.

[unknownbrackets]

I wouldn't be against a joystick, though some might expect that to scroll between save items.

It could be something like hold the R key + up/down, since there's a legend at the bottom already. If it's only slightly taller, I think smaller makes more sense. In this case, it probably has up to 4 names and levels, so scrolling would probably be better.

An argument against (though I think this is doubtful) is that perhaps some games have garbage after several \n\ns that they didn't care about since no one could see them anyway.

-[Unknown]