Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekken 6 Bonus Stage Nancy laser beam is invisible (lines) #15756

Closed
5 tasks done
ghost opened this issue Jul 30, 2022 · 12 comments · Fixed by #16067
Closed
5 tasks done

Tekken 6 Bonus Stage Nancy laser beam is invisible (lines) #15756

ghost opened this issue Jul 30, 2022 · 12 comments · Fixed by #16067
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@ghost
Copy link

ghost commented Jul 30, 2022

Game or games this happens in

ULES01376

What area of the game

ppsspp v1.13.1 Nancy laser beam is invisible.
Screenshot_2022-07-30-09-02-59-333_org ppsspp ppsspp

ppsspp v1.12.3 Nancy laser beam is visible
Screenshot_2022-07-30-09-03-23-299_org ppsspp ppssppgold

What happens

Nancy laser beam is invisible.

What should happen

Nancy laser beam should be visible.

GE frame capture

ULES01376.ppdmp.zip

Platform

Android

Mobile phone model or graphics card

Redmi Note 9 Android 12 Helio G85 Mali-G52 GPU

PPSSPP version affected

v1.13.1

Last working version

v1.12.3

Graphics backend (3D API)

Vulkan/OpenGL

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
  • Include logs or screenshots of issue.
@hrydgard hrydgard added this to the v1.14.0 milestone Jul 30, 2022
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jul 30, 2022
@hrydgard
Copy link
Owner

Thanks for the report! Likely related to the new line drawing method.

@hrydgard hrydgard changed the title (Android) (OGL/VK) Tekken 6 Bonus Stage Nancy laser beam is invincible (Android) (OGL/VK) Tekken 6 Bonus Stage Nancy laser beam is invisible Jul 30, 2022
@hrydgard
Copy link
Owner

hrydgard commented Aug 23, 2022

rRootage seems impacted according to Panderner on Discord:

image

@Panderner
Copy link
Contributor

Here:
RROO00643.zip

@ghost
Copy link
Author

ghost commented Sep 10, 2022

Tekken 6 is crashing on the latest build if set to skip buffers rendering!

@hrydgard
Copy link
Owner

Yeah, I'm not testing much with it off, I highly recommend to turn on buffered rendering. But I'll fix it of course.

@hrydgard hrydgard changed the title (Android) (OGL/VK) Tekken 6 Bonus Stage Nancy laser beam is invisible (Android) (OGL/VK) Tekken 6 Bonus Stage Nancy laser beam is invisible (lines) Sep 10, 2022
@hrydgard hrydgard changed the title (Android) (OGL/VK) Tekken 6 Bonus Stage Nancy laser beam is invisible (lines) Tekken 6 Bonus Stage Nancy laser beam is invisible (lines) Sep 10, 2022
@ghost
Copy link
Author

ghost commented Sep 11, 2022

Tekken 6 is crashing on the latest build if set to skip buffers rendering!

Juice 2 is also crashing using skip buffers rendering and some other games I tried.

@hrydgard
Copy link
Owner

Yeah, I'll get around to fixing that soon.

@hrydgard
Copy link
Owner

hrydgard commented Sep 20, 2022

So the issue here is that the line is actually drawn, it's just so ridiculously thin that it doesn't cover more than a pixel or two, so something is wrong with the line expansion math. The GE dump reproduces the error perfectly.

The following change makes it look good, which is of course a ridiculous change to make:

			Vec2f addWidth = Vec2f(-vertical, horizontal).Normalized() * 10000.0f;

image

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Sep 20, 2022
See hrydgard#15756, frame was largely black because of a full screen blend
rectangle intended to brighten the screen slighty (I assume.)
@unknownbrackets
Copy link
Collaborator

The beam looks like this on a PSP:
#15756_ULES01376_tekken_beam_line

The software renderer (with #16066) gets close, just slightly off:
#15756_ULES01376_tekken_beam_line_softgpu

The line drawn at 5780/5813 uses addWidth: 0.985653,0.168787 dx/dy: 0.004167,0.007353, or 0.00410721605 width for the rectangle. That's slightly less than 1 pixel. In renderdoc, it's the last indexed draw in the first render pass.

But in the render doc the positions are not different, however. There's only two unique xyzw values going in or out of the vertex shader. Which now makes sense, because of course, w. That's why it's not adding anything after transform. D'oh.

-[Unknown]

@ghost
Copy link
Author

ghost commented Oct 3, 2022

Tekken 6 is crashing on the latest build if set to skip buffers rendering!

I can exibit this issue again in the recent build.

@hrydgard
Copy link
Owner

hrydgard commented Oct 3, 2022

crash on skip buffers? I'll get that fixed soon.

@ghost
Copy link
Author

ghost commented Oct 3, 2022

crash on skip buffers? I'll get that fixed soon.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants