(Adreno)(Vulkan) Burnout Legends freeze since #15589

[ghost]

Game or games this happens in

ULUS-10025

What area of the game

Selecting cars before racing

What happens

There's a new issue related to this game but now on my vivo y11 adreno 505 using vulkan issue started in #15589

Screenrecording_20221101_234404.mp4

What should happen

No freeze/hang like in opengl

GE frame capture

No response

Platform

Android

Mobile phone model or graphics card

Vivo Y11 Android 11 Snapdragon 439 Adreno 505

PPSSPP version affected

v1.13.1-690

Last working version

v1.13.1

Graphics backend (3D API)

Vulkan

Checklist

• Test in the latest git build in case it's already fixed.
• Search for other reports of the same issue.
• Try resetting settings or older versions and include if the issue is related.
• Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
• Include logs or screenshots of issue.

[hrydgard]

That's really curious that just this phone would start having problems at that commit. I'll see if I can repro.

[hrydgard]

OK I can actually reproduce this on my Pixel 3a, so that's a good start! Won't need any testing help :)

I turned off the parallelism that -690 introduced and it still happens, so it's something else and I kinda doubt it's that specific commit?

Anyway, what I'm getting is [G3D] Failed creating graphics pipeline! result='VK_ERROR_...(unknown)', and we hang right after since we don't handle pipeline creation errors well.

[hrydgard]

Haha, okay, the shader must have failed to compile before too, it's just that that PR caused things to start hanging on failed shaders.

And the reason it failed to compile is that for the offending pipeline, is that the fragment shader always does "discard", which the buggy driver doesn't like. And it always discards because the alpha test is set to NEVER which means nothing is ever drawn - which means that it hardly matters if this pipeline fails anyway, heh.

I'm making things more robust to failures, and adding more logging etc.