Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan validation layers just got pickier about input attachments #16351

Closed
hrydgard opened this issue Nov 6, 2022 · 1 comment
Closed

Vulkan validation layers just got pickier about input attachments #16351

hrydgard opened this issue Nov 6, 2022 · 1 comment
Labels

Comments

@hrydgard
Copy link
Owner

hrydgard commented Nov 6, 2022

Reminder to self for tomorrow.

We fail the new check KhronosGroup/Vulkan-ValidationLayers@7acdcd6 (which is in the latest SDK validation layers), since we end up binding a different view of the same image as the input attachment and the descriptor, which is no longer ok. Shouldn't be too hard to fix. (VKRImage rtView vs texAllLayersView, I believe).

@hrydgard hrydgard added the Vulkan label Nov 6, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Nov 6, 2022
hrydgard added a commit that referenced this issue Nov 7, 2022
…nt, not just the same image

Fixes most of the new validation errors seen #16351, though one remains.

I believe that to be a bug in the validation layers, will investigate
later.
@hrydgard hrydgard removed this from the v1.14.0 milestone Nov 13, 2022
@hrydgard
Copy link
Owner Author

I've fixed what I can, and then forcibly disabled these checks for now, and Hans-Kristian agrees with me that the validation (and spec rule) isn't right - so closing, nothing to do other than waiting for updated validation layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant