Retroachievements support (work-in-progress) #17589

hrydgard · 2023-06-17T09:50:47Z

Implement RetroAchievements support (#16169). Not to be confused with RetroArch, these are two different projects.

Most of RetroAchievements.cpp was adapted from DuckStation's integration by @stenzek.

So far, login works (unless you're on a touchscreen device), game identification and basic achievement listing works, and unlocking achivements works.

TODO list before initial merge:

Login UI, basic settings
Proper achievement listing UI from the pause screen
On-screen notification UI for unlocks
Fix the game hashing so it can work with scoped storage
More secure login token storage
Fill in the remaining translation strings in en_US.ini (will add actual translations in the next PR)

Next steps after this:

Leaderboards UI
HTTPS support (we force HTTP because our client implemenetation lacks ssl support)
Challenge mode (disable savestates etc)
Juicy sound effect for unlocks
Other missing features

cannnAvar · 2023-06-17T13:48:32Z

How we can use achivements now

hrydgard · 2023-06-17T14:23:38Z

Stay tuned, it's not ready enough yet.

hrydgard · 2023-06-17T21:54:09Z

Rebased on top of #17594 .

stenzek · 2023-06-18T10:44:13Z

Got pinged about this, please maintain my copyright notice in DuckStation-derived files (and add your own, obviously), thanks.

Also, feel free to relicense those files to GPL2 to match the rest of the emu if that makes things easier (in DS it's GPL3).

hrydgard · 2023-06-18T10:57:41Z

@stenzek will do, thank you!

hrydgard · 2023-06-21T13:53:10Z

Progress report: You can now login through the UI, and play and get achievements, and you do get nice little popups with achievement icons and text when you do. There is also an achievement list on the pause screen, if achievements are enabled for the game. Logging in works on all desktop platforms currently - or if you have a physical keyboard for your phone somehow. This will of course be fixed soon.

I'll do a more general fix for text input UIs on master soon, then bring it into this PR.

EDIT: Confirmed working fine on Android except a weird centering issue, the code updates are coming soon.

hrydgard · 2023-06-22T07:34:10Z

This is starting to get usable now, opening for review, but don't merge until the below is solved:

I think we should probably store the RetroAchievements login token somewhere slightly more secure than in PPSSPP.ini, it's too easy to accidentally leak your token while sending that file in for debugging or something.

On Android we'll just store it in a file in the app private directory.

On Windows, Mac, Linux, I'm thinking just store it in a separate file in the home directory somewhere?

Captainquill · 2023-06-25T09:13:54Z

Hello sir.. When will this be ready to download. Just a tentative release Window.?

hrydgard · 2023-06-25T11:51:09Z

Next week it will be in the "nightly" builds.

anr2me · 2023-06-25T18:22:34Z

Hello sir.. When will this be ready to download. Just a tentative release Window.?

Currently you can also download the artifacts from https://github.com/hrydgard/ppsspp/actions/runs/5360144898?pr=17589 if you want to test it.

…_address

…gin left to do)

…oid (other platforms not so good)

…al slash.

hrydgard · 2023-06-26T08:15:02Z

Should be ready for initial review/merge now.

hrydgard · 2023-06-26T08:38:46Z

Hm, actually need to clean up the choice of directory for secrets storage. It's not making good choices on some platforms.

hrydgard · 2023-06-26T14:51:40Z

Ok, I've been thinking about where to put the login token on various platforms. One idea would be the following:

Android: It clearly belongs in the app private data folder.
Windows: There are two cases here:
- installed: %APPDATA%\PPSSPP ?
- portable: memstick/PSP/SYSTEM , next to the ini (but not included in the ini file)
Linux/Mac: memstick/PSP/SYSTEM
iOS: ?
Switch: ?

However, after some chats I think I might be overthinking it. It's only really important to keep it out of the .ini as we often ask people to post that. But just putting the login token in a file next to the ini on all platforms may be good enough, really.

hrydgard · 2023-06-26T22:13:45Z

Alright, I think this is a pretty good checkpoint, and I'm just gonna get it in and work from that state.

unknownbrackets · 2023-07-15T17:51:57Z

Common/UI/IconCache.h

+	// for testing
+	std::string GetFirstIconName() const {


Not sure what this is for specifically, but it should be using lock_ in case someone starts calling it later.

-[Unknown]

I never used it for anything, I'll just delete it. Was gonna be used to test achievement popups without getting achievements.

hrydgard added the User Interface PPSSPP's own user interface / UX label Jun 17, 2023

hrydgard added this to the v1.16.0 milestone Jun 17, 2023

hrydgard marked this pull request as draft June 17, 2023 09:50

hrydgard mentioned this pull request Jun 17, 2023

Feature Request [Add Achievements login from Retroachievements.org] #16169

Closed

2 tasks

hrydgard mentioned this pull request Jun 17, 2023

Port some fixes/improvements from the retroachievements branch #17594

Merged

hrydgard force-pushed the retroachievements-initial-work branch from 5da62b4 to b5d33e6 Compare June 17, 2023 21:42

hrydgard mentioned this pull request Jun 18, 2023

UI: Icon image cache #17599

Merged

hrydgard force-pushed the retroachievements-initial-work branch 2 times, most recently from 8f113fe to 58e9afd Compare June 18, 2023 14:06

hrydgard mentioned this pull request Jun 20, 2023

On-screen messages refactoring #17605

Merged

hrydgard force-pushed the retroachievements-initial-work branch 2 times, most recently from cb0d65f to ca82a6a Compare June 21, 2023 10:18

hrydgard mentioned this pull request Jun 21, 2023

Text input: Have PopupTextInputChoice use native text input if available #17611

Merged

hrydgard force-pushed the retroachievements-initial-work branch from 60f2cea to 9242066 Compare June 22, 2023 07:30

hrydgard marked this pull request as ready for review June 22, 2023 07:34

hrydgard force-pushed the retroachievements-initial-work branch from 9242066 to ee30ce5 Compare June 22, 2023 08:27

hrydgard added 4 commits June 26, 2023 10:01

rcheevos initial build setup and basic scaffolding

c0f0c05

Start sketching on a wrapper

da1691e

Copy-paste retroachievement support from DuckStation. No fixes yet!

4745999

Initial batch of fixes. Not compiling yet, http will be the tricky one.

029b887

hrydgard added 13 commits June 26, 2023 10:01

Hook up progress bar, minor fixes

3b6989b

De-spam the logs

da36d78

Attempt to add memory access validation through rc_runtime_invalidate…

3218422

…_address

Show progress when downloading achievement data

078002d

Implement rendering of unlocked achievements. Not final design.

c442d1d

A bunch of visual updates and fixes. Lots left to polish.

69a5ca0

Fix

9502d55

Set up a custom rc_hash_filereader to make things work on Android (lo…

d63415d

…gin left to do)

Login: Support desktop platforms other than Windows.

b0dc1db

Visual improvements, notify if game unknown to RetroAchievements

37fb3be

Add simple facility for storing secret in app-private storage on Andr…

87846c5

…oid (other platforms not so good)

Path: If a Path is empty, the slash operator will not add an addition…

864b2bb

…al slash.

Use the new "secret storage" to store the retroachievements token

4134acc

hrydgard force-pushed the retroachievements-initial-work branch from 37a557c to 4134acc Compare June 26, 2023 08:02

Achivement list rendering fix (wrong alpha)

23e37b7

hrydgard added 2 commits June 26, 2023 17:09

Keeping it simple - putting the token in memstick/PSP/SYSTEM for now

d4239e7

Token name and path fix

81e1293

hrydgard merged commit 01cf22e into master Jun 26, 2023

hrydgard deleted the retroachievements-initial-work branch June 26, 2023 22:13

hrydgard added RetroAchievements RetroAchievements related work and removed User Interface PPSSPP's own user interface / UX labels Jun 27, 2023

hrydgard mentioned this pull request Jun 27, 2023

RetroAchievements: Remaining features to implement #17631

Closed

34 tasks

unknownbrackets reviewed Jul 15, 2023

View reviewed changes

retropieuser mentioned this pull request Jul 20, 2023

[Feature Request]RetroAchievements melonDS-emu/melonDS#1146

Open

jbeich mentioned this pull request Sep 9, 2023

Unbreak build on FreeBSD #18114

Merged

nighto mentioned this pull request May 17, 2024

[Feature Request]: RetroAchievements support Vita3K/Vita3K#3296

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retroachievements support (work-in-progress) #17589

Retroachievements support (work-in-progress) #17589

hrydgard commented Jun 17, 2023 •

edited

Loading

cannnAvar commented Jun 17, 2023

hrydgard commented Jun 17, 2023

hrydgard commented Jun 17, 2023

stenzek commented Jun 18, 2023

hrydgard commented Jun 18, 2023

hrydgard commented Jun 21, 2023 •

edited

Loading

hrydgard commented Jun 22, 2023

Captainquill commented Jun 25, 2023

hrydgard commented Jun 25, 2023

anr2me commented Jun 25, 2023

hrydgard commented Jun 26, 2023

hrydgard commented Jun 26, 2023 •

edited

Loading

hrydgard commented Jun 26, 2023 •

edited

Loading

hrydgard commented Jun 26, 2023

unknownbrackets Jul 15, 2023

hrydgard Jul 15, 2023 •

edited

Loading

Retroachievements support (work-in-progress) #17589

Retroachievements support (work-in-progress) #17589

Conversation

hrydgard commented Jun 17, 2023 • edited Loading

cannnAvar commented Jun 17, 2023

hrydgard commented Jun 17, 2023

hrydgard commented Jun 17, 2023

stenzek commented Jun 18, 2023

hrydgard commented Jun 18, 2023

hrydgard commented Jun 21, 2023 • edited Loading

hrydgard commented Jun 22, 2023

Captainquill commented Jun 25, 2023

hrydgard commented Jun 25, 2023

anr2me commented Jun 25, 2023

hrydgard commented Jun 26, 2023

hrydgard commented Jun 26, 2023 • edited Loading

hrydgard commented Jun 26, 2023 • edited Loading

hrydgard commented Jun 26, 2023

unknownbrackets Jul 15, 2023

Choose a reason for hiding this comment

hrydgard Jul 15, 2023 • edited Loading

Choose a reason for hiding this comment

hrydgard commented Jun 17, 2023 •

edited

Loading

hrydgard commented Jun 21, 2023 •

edited

Loading

hrydgard commented Jun 26, 2023 •

edited

Loading

hrydgard commented Jun 26, 2023 •

edited

Loading

hrydgard Jul 15, 2023 •

edited

Loading